* [Ada] Remove unnecessary guards for appending non-empty lists
@ 2022-01-07 16:27 Pierre-Marie de Rodat
0 siblings, 0 replies; only message in thread
From: Pierre-Marie de Rodat @ 2022-01-07 16:27 UTC (permalink / raw)
To: gcc-patches; +Cc: Piotr Trojanek
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Calls to Append_List and Append_List_To applied with empty lists do
nothing, so there is no need to explicitly guard against such calls.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* exp_ch3.adb (Build_Init_Procedure): Remove unnecessary guard.
* exp_disp.adb (Make_DT): Likewise.
* sem_ch12.adb (Analyze_Associations): Likewise.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1528 bytes --]
diff --git a/gcc/ada/exp_ch3.adb b/gcc/ada/exp_ch3.adb
--- a/gcc/ada/exp_ch3.adb
+++ b/gcc/ada/exp_ch3.adb
@@ -2885,9 +2885,7 @@ package body Exp_Ch3 is
Fixed_Comps => False,
Variable_Comps => True);
- if Is_Non_Empty_List (Init_Tags_List) then
- Append_List_To (Body_Stmts, Init_Tags_List);
- end if;
+ Append_List_To (Body_Stmts, Init_Tags_List);
end if;
end if;
diff --git a/gcc/ada/exp_disp.adb b/gcc/ada/exp_disp.adb
--- a/gcc/ada/exp_disp.adb
+++ b/gcc/ada/exp_disp.adb
@@ -6379,9 +6379,7 @@ package body Exp_Disp is
New_List (New_Occurrence_Of (DT_Ptr, Loc))));
end if;
- if not Is_Empty_List (Elab_Code) then
- Append_List_To (Result, Elab_Code);
- end if;
+ Append_List_To (Result, Elab_Code);
-- Populate the two auxiliary tables used for dispatching asynchronous,
-- conditional and timed selects for synchronized types that implement
diff --git a/gcc/ada/sem_ch12.adb b/gcc/ada/sem_ch12.adb
--- a/gcc/ada/sem_ch12.adb
+++ b/gcc/ada/sem_ch12.adb
@@ -2248,9 +2248,7 @@ package body Sem_Ch12 is
-- explicit box associations for the formals that are covered by an
-- Others_Choice.
- if not Is_Empty_List (Default_Formals) then
- Append_List (Default_Formals, Formals);
- end if;
+ Append_List (Default_Formals, Formals);
return Assoc_List;
end Analyze_Associations;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-07 16:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 16:27 [Ada] Remove unnecessary guards for appending non-empty lists Pierre-Marie de Rodat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).