From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 27A41389CF7A for ; Tue, 11 Jan 2022 09:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27A41389CF7A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-381-KDajxtx6MFKONnQ68gkQrw-1; Tue, 11 Jan 2022 04:43:23 -0500 X-MC-Unique: KDajxtx6MFKONnQ68gkQrw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D92B11018727; Tue, 11 Jan 2022 09:43:22 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 826386E1FF; Tue, 11 Jan 2022 09:43:22 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20B9hJFs1103644 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 10:43:20 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20B9hI6c1103643; Tue, 11 Jan 2022 10:43:18 +0100 Date: Tue, 11 Jan 2022 10:43:18 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v6 1/4] tree-object-size: Support dynamic sizes in conditions Message-ID: <20220111094318.GR2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20220111085750.1900047-1-siddhesh@gotplt.org> <20220111085750.1900047-2-siddhesh@gotplt.org> MIME-Version: 1.0 In-Reply-To: <20220111085750.1900047-2-siddhesh@gotplt.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 09:43:29 -0000 On Tue, Jan 11, 2022 at 02:27:47PM +0530, Siddhesh Poyarekar wrote: > Handle GIMPLE_PHI and conditionals specially for dynamic objects, > returning PHI/conditional expressions instead of just a MIN/MAX > estimate. > > This makes the returned object size variable for loops and conditionals, > so tests need to be adjusted to look for precise size in some cases. > builtin-dynamic-object-size-5.c had to be modified to only look for > success in maximum object size case and skip over the minimum object > size tests because the result is no longer a compile time constant. > > I also added some simple tests to exercise conditionals with dynamic > object sizes. Ok, but IMO please fix PR103961 first before committing this patchset. > gcc/ChangeLog: > > * builtins.c (fold_builtin_object_size): Adjust for dynamic size > expressions. > * tree-object-size.c: Include gimplify-me.h. > (struct object_size_info): New member UNKNOWNS. > (size_initval_p, size_usable_p, object_sizes_get_raw): New > functions. > (object_sizes_get): Return suitable gimple variable for > object size. > (bundle_sizes): New function. > (object_sizes_set): Use it and handle dynamic object size > expressions. > (object_sizes_set_temp): New function. > (size_for_offset): Adjust for dynamic size expressions. > (emit_phi_nodes, propagate_unknowns, gimplify_size_expressions): > New functions. > (compute_builtin_object_size): Call gimplify_size_expressions > for OST_DYNAMIC. > (dynamic_object_size): New function. > (cond_expr_object_size): Use it. > (phi_dynamic_object_size): New function. > (collect_object_sizes_for): Call it for OST_DYNAMIC. Adjust to > accommodate dynamic object sizes. > > gcc/testsuite/ChangeLog: > > * gcc.dg/builtin-dynamic-object-size-0.c: New tests. > * gcc.dg/builtin-dynamic-object-size-10.c: Add comment. > * gcc.dg/builtin-dynamic-object-size-5-main.c: New file. > * gcc.dg/builtin-dynamic-object-size-5.c: Use it and change test > to dg-do run. > * gcc.dg/builtin-object-size-5.c [!N]: Define N. > (test1, test2, test3, test4) [__builtin_object_size]: Expect > exact result for __builtin_dynamic_object_size. > * gcc.dg/builtin-object-size-1.c [__builtin_object_size]: Expect > exact size expressions for __builtin_dynamic_object_size. > * gcc.dg/builtin-object-size-2.c [__builtin_object_size]: > Likewise. > * gcc.dg/builtin-object-size-3.c [__builtin_object_size]: > Likewise. > * gcc.dg/builtin-object-size-4.c [__builtin_object_size]: > Likewise. > * gcc.dg/builtin-object-size-5.c [__builtin_object_size]: > Likewise. Jakub