From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0F911389F069 for ; Tue, 11 Jan 2022 09:45:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F911389F069 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-XjMDbI6nMHGF6_d6avrcQg-1; Tue, 11 Jan 2022 04:44:59 -0500 X-MC-Unique: XjMDbI6nMHGF6_d6avrcQg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42B2284BA43; Tue, 11 Jan 2022 09:44:58 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D03E57CAF4; Tue, 11 Jan 2022 09:44:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20B9itFs1103658 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 10:44:55 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20B9inot1103657; Tue, 11 Jan 2022 10:44:49 +0100 Date: Tue, 11 Jan 2022 10:44:49 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v6 2/4] tree-object-size: Handle function parameters Message-ID: <20220111094449.GS2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20220111085750.1900047-1-siddhesh@gotplt.org> <20220111085750.1900047-3-siddhesh@gotplt.org> MIME-Version: 1.0 In-Reply-To: <20220111085750.1900047-3-siddhesh@gotplt.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 09:45:03 -0000 On Tue, Jan 11, 2022 at 02:27:48PM +0530, Siddhesh Poyarekar wrote: > Handle hints provided by __attribute__ ((access (...))) to compute > dynamic sizes for objects. > > gcc/ChangeLog: > > * tree-object-size.c: Include tree-dfa.h. > (parm_object_size): New function. > (collect_object_sizes_for): Call it. > > gcc/testsuite/ChangeLog: > > * gcc.dg/builtin-dynamic-object-size-0.c (test_parmsz_simple, > test_parmsz_scaled, test_parmsz_unknown): New functions. > (main): Call them. Add new arguments argc and argv. > > Signed-off-by: Siddhesh Poyarekar > + /* Walk through the parameters to pick the size parameter and safely > + scale it by the type size. */ > + for (arg = fnargs; arg; arg = TREE_CHAIN (arg), ++argpos) > + { > + if (argpos == access->sizarg && INTEGRAL_TYPE_P (TREE_TYPE (arg))) > + { > + sz = get_or_create_ssa_default_def (cfun, arg); > + if (sz != NULL_TREE) > + { > + sz = fold_convert (sizetype, sz); > + if (typesize) > + sz = size_binop (MULT_EXPR, sz, typesize); > + } > + break; > + } > + } No need for those {}s around the if as body of for, just use for (arg = fnargs; arg; arg = TREE_CHAIN (arg), ++argpos) if (argpos == access->sizarg && INTEGRAL_TYPE_P (TREE_TYPE (arg))) { ... break; } Ok with that change. Jakub