From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4DE8E389F06C for ; Tue, 11 Jan 2022 09:47:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4DE8E389F06C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-391-WtHOepnAMDeKjFjAdFddKw-1; Tue, 11 Jan 2022 04:47:36 -0500 X-MC-Unique: WtHOepnAMDeKjFjAdFddKw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A209581CCB5; Tue, 11 Jan 2022 09:47:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C8276E217; Tue, 11 Jan 2022 09:47:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20B9lWYT1103674 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 10:47:32 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20B9lVk41103673; Tue, 11 Jan 2022 10:47:31 +0100 Date: Tue, 11 Jan 2022 10:47:31 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v6 4/4] tree-object-size: Dynamic sizes for ADDR_EXPR Message-ID: <20220111094731.GT2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20220111085750.1900047-1-siddhesh@gotplt.org> <20220111085750.1900047-5-siddhesh@gotplt.org> MIME-Version: 1.0 In-Reply-To: <20220111085750.1900047-5-siddhesh@gotplt.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 09:47:39 -0000 On Tue, Jan 11, 2022 at 02:27:50PM +0530, Siddhesh Poyarekar wrote: > Allow returning dynamic expressions from ADDR_EXPR for > __builtin_dynamic_object_size and also allow offsets to be dynamic. > > gcc/ChangeLog: > > * tree-object-size.c (size_valid_p): New function. > (size_for_offset): Remove OFFSET constness assertion. > (addr_object_size): Build dynamic expressions for object > sizes and use size_valid_p to decide if it is valid for the > given OBJECT_SIZE_TYPE. > (compute_builtin_object_size): Allow dynamic offsets when > computing size at O0. > (call_object_size): Call size_valid_p. > (plus_stmt_object_size): Allow non-constant offset and use > size_valid_p to decide if it is valid for the given > OBJECT_SIZE_TYPE. > > gcc/testsuite/ChangeLog: > > * gcc.dg/builtin-dynamic-object-size-0.c: Add new tests. > * gcc.dg/builtin-object-size-1.c (test1) > [__builtin_object_size]: Adjust expected output for dynamic > object sizes. > * gcc.dg/builtin-object-size-2.c (test1) > [__builtin_object_size]: Likewise. > * gcc.dg/builtin-object-size-3.c (test1) > [__builtin_object_size]: Likewise. > * gcc.dg/builtin-object-size-4.c (test1) > [__builtin_object_size]: Likewise. > +/* Return true if VAL is represents a valid size for OBJECT_SIZE_TYPE. */ s/is / as in the other patch. Otherwise LGTM. Jakub