From: Jakub Jelinek <jakub@redhat.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Chenghua Xu <xuchenghua@loongson.cn>,
gcc-patches@gcc.gnu.org, chenglulu@loongson.cn,
joseph@codesourcery.com
Subject: Re: [PATCH v5 02/12] LoongArch Port: gcc build
Date: Sat, 22 Jan 2022 09:41:23 +0100 [thread overview]
Message-ID: <20220122084123.GR2646553@tucnak> (raw)
In-Reply-To: <7ce56cd6443ff31d87eba76ceda2cb888d1d8848.camel@mengyan1223.wang>
On Sat, Jan 22, 2022 at 04:33:08PM +0800, Xi Ruoyao via Gcc-patches wrote:
> On Sat, 2022-01-22 at 15:55 +0800, Chenghua Xu wrote:
> > +$(srcdir)/config/loongarch/loongarch.opt: \
> > + $(srcdir)/config/loongarch/genopts/genstr.sh \
> > + $(srcdir)/config/loongarch/genopts/loongarch.opt.in
> > + $(SHELL) $< opt > $@
> > +
> > +$(LA_STR_H): \
> > + $(srcdir)/config/loongarch/genopts/genstr.sh \
> > + $(srcdir)/config/loongarch/genopts/loongarch-strings
> > + $(SHELL) $< header > $@
>
> I'm not sure about these two rules: is it allowed to modify files in
> $(srcdir) running "make"?
No (except in --enable-maintainer-mode), but the above certainly
looks wrong, both should be in the objdir instead.
Jakub
next prev parent reply other threads:[~2022-01-22 8:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 7:55 [PATCH v5 00/12] Add LoongArch support Chenghua Xu
2022-01-22 7:55 ` [PATCH v5 01/12] LoongArch Port: Regenerate configure Chenghua Xu
2022-01-22 7:55 ` [PATCH v5 02/12] LoongArch Port: gcc build Chenghua Xu
2022-01-22 8:33 ` Xi Ruoyao
2022-01-22 8:41 ` Jakub Jelinek [this message]
2022-01-22 8:46 ` Xi Ruoyao
2022-01-22 8:56 ` 程璐璐
2022-01-22 9:05 ` Xi Ruoyao
2022-01-22 9:16 ` 程璐璐
2022-01-22 9:24 ` Andreas Schwab
2022-01-22 9:31 ` Jakub Jelinek
2022-01-22 10:35 ` 程璐璐
2022-01-23 8:16 ` 程璐璐
2022-01-22 8:34 ` Xi Ruoyao
2022-01-22 8:42 ` Xi Ruoyao
2022-01-23 8:39 ` 程璐璐
2022-01-23 9:00 ` Xi Ruoyao
2022-01-23 9:28 ` 程璐璐
2022-01-22 7:55 ` [PATCH v5 03/12] LoongArch Port: Regenerate gcc/configure Chenghua Xu
2022-01-22 7:55 ` [PATCH v5 04/12] LoongArch Port: Machine Decsription files Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 05/12] LoongArch Port: Machine description C files and .h files Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 06/12] LoongArch Port: Builtin functions Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 07/12] LoongArch Port: Builtin macros Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 08/12] LoongArch Port: libgcc Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 09/12] LoongArch Port: Regenerate libgcc/configure Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 10/12] LoongArch Port: libgomp Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 11/12] LoongArch Port: gcc/testsuite Chenghua Xu
2022-01-22 7:56 ` [PATCH v5 12/12] LoongArch Port: Add doc Chenghua Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122084123.GR2646553@tucnak \
--to=jakub@redhat.com \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=xry111@mengyan1223.wang \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).