From: Jakub Jelinek <jakub@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "Martin Liška" <mliska@suse.cz>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
soeren@soeren-tempel.net
Subject: Re: [PATCH] Disable -fsplit-stack support on non-glibc targets
Date: Sun, 23 Jan 2022 11:06:37 +0100 [thread overview]
Message-ID: <20220123100637.GC2646553@tucnak> (raw)
In-Reply-To: <CAFULd4ZjnUqEmjQ+h9DJVxNoE=MNN6SE787Hh48SPsABsPR1Qg@mail.gmail.com>
On Sun, Jan 23, 2022 at 10:06:24AM +0100, Uros Bizjak wrote:
> > 2022-01-22 Jakub Jelinek <jakub@redhat.com>
> >
> > * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> > OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> > using OPTION_*_P macros.
> > * config/alpha/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> > OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> > using OPTION_*_P macros.
> > * config/rs6000/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> > OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> > using OPTION_*_P macros.
> > * config/rs6000/linux64.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> > OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> > (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> > using OPTION_*_P macros.
> > * config/fuchsia.h (OPTION_MUSL_P): Redefine.
> > * config/glibc-stdint.h (OPTION_MUSL_P): Define if not defined.
> > * common/config/s390/s390-common.cc (s390_supports_split_stack): Re-add
> > ATTRIBUTE_UNUSED to opts parameter. If OPTION_GLIBC_P is defined, use
> > OPTION_GLIBC_P (opts) as condition, otherwise assume if (false).
> > * common/config/i386/i386-common.cc (ix86_supports_split_stack): If
> > OPTION_GLIBC_P is defined use !OPTION_GLIBC_P (opts) as condition,
> > otherwise assume if (true).
>
> I wonder why every target defines its own set of #defines. I'd expect
> that they include toplevel gcc/config/linux.h and inherit these
> defines from it.
Not every target, most of the Linux targets do use config/linux.h,
just ppc* and alpha haven't been converted to do so.
It would be nice to have that done at some point, but to me that
looks like stage1 task rather than stage4.
Jakub
next prev parent reply other threads:[~2022-01-23 10:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 10:43 soeren
2021-12-18 10:54 ` Andrew Pinski
2021-12-18 11:13 ` Sören Tempel
2021-12-18 11:22 ` Andrew Pinski
2021-12-18 12:19 ` [PATCH v2] " soeren
2022-01-20 20:45 ` Sören Tempel
2022-01-20 22:52 ` Richard Sandiford
2022-01-21 7:32 ` Andreas Krebbel
2022-01-21 8:17 ` Uros Bizjak
2022-01-21 19:16 ` [PATCH v3] " soeren
2022-01-21 19:23 ` Richard Sandiford
2022-01-21 19:47 ` H.J. Lu
2022-01-21 20:09 ` H.J. Lu
2022-01-21 20:18 ` Jakub Jelinek
2022-01-21 21:31 ` [PATCH] x86: Properly disable " H.J. Lu
2022-01-21 21:42 ` Jakub Jelinek
2022-01-21 21:57 ` [PATCH v2] " H.J. Lu
2022-01-21 22:14 ` Jakub Jelinek
2022-01-21 19:53 ` [PATCH v2] Disable " H.J. Lu
2022-01-21 20:43 ` Sören Tempel
2022-01-22 9:32 ` [PATCH] " Martin Liška
2022-01-22 9:35 ` Jakub Jelinek
2022-01-22 12:16 ` Jakub Jelinek
2022-01-22 18:03 ` Jakub Jelinek
2022-01-23 9:06 ` Uros Bizjak
2022-01-23 10:06 ` Jakub Jelinek [this message]
2022-01-24 9:33 ` Jakub Jelinek
2022-01-24 10:09 ` Richard Biener
2022-01-25 15:27 David Edelsohn
2022-01-28 19:25 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220123100637.GC2646553@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=soeren@soeren-tempel.net \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).