From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 41A943850412 for ; Wed, 26 Jan 2022 11:10:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41A943850412 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-R2KqDJ0ON_WBs6AOWxw5YA-1; Wed, 26 Jan 2022 06:09:58 -0500 X-MC-Unique: R2KqDJ0ON_WBs6AOWxw5YA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 444A264140; Wed, 26 Jan 2022 11:09:57 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C53441059A74; Wed, 26 Jan 2022 11:09:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20QB9rsk2279810 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 26 Jan 2022 12:09:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20QB9q7h2279809; Wed, 26 Jan 2022 12:09:52 +0100 Date: Wed, 26 Jan 2022 12:09:52 +0100 From: Jakub Jelinek To: "H.J. Lu" Cc: Hongtao Liu , liuhongt , GCC Patches Subject: Re: [PATCH v2] x86: Also check mode of memory broadcast in bcst_mem_operand Message-ID: <20220126110952.GR2646553@tucnak> Reply-To: Jakub Jelinek References: <20220123122816.345498-1-hjl.tools@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 11:10:03 -0000 On Sun, Jan 23, 2022 at 04:39:34PM -0800, H.J. Lu via Gcc-patches wrote: > On Sun, Jan 23, 2022 at 4:35 PM Hongtao Liu wrote: > > > > On Sun, Jan 23, 2022 at 8:28 PM H.J. Lu via Gcc-patches > > wrote: > > > > > > Return false for invalid mode on memory broadcast in bcst_mem_operand: > > > > > > (vec_duplicate:V16SF (mem/j:V4SF (reg/v/f:DI 109 [ b ]))) > > > > > Yes, thanks. > > I will also backport it to GCC 11 branch. On i686-linux this new testcase FAILs with: cc1: warning: SSE instruction set disabled, using 387 arithmetics FAIL: gcc.target/i386/pr104188.c (test for excess errors) Excess errors: cc1: warning: SSE instruction set disabled, using 387 arithmetics This is because it uses -mfpmath=sse, but -msse2 isn't on. Fixed by adding -msse2 to dg-options and requiring sse2_runtime effective target. Tested on x86_64-linux and i686-linux, committed as obvious to trunk/11: 2022-01-26 Jakub Jelinek PR target/104188 * gcc.target/i386/pr104188.c: Add dg-require-effective-target sse2_runtime. Add -msse2 to dg-options. --- gcc/testsuite/gcc.target/i386/pr104188.c.jj 2022-01-24 10:18:21.174512441 +0100 +++ gcc/testsuite/gcc.target/i386/pr104188.c 2022-01-26 11:54:58.025950692 +0100 @@ -1,5 +1,6 @@ /* { dg-do run { target avx512f } } */ -/* { dg-options "-O2 -mfpmath=sse" } */ +/* { dg-require-effective-target sse2_runtime } */ +/* { dg-options "-O2 -msse2 -mfpmath=sse" } */ #include Jakub