From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++ testsuite: Don't run lwg3464.cc tests on simulators to 20
Date: Sun, 30 Jan 2022 19:05:19 +0100 [thread overview]
Message-ID: <20220130180519.AE8EB2041A@pchp3.se.axis.com> (raw)
In-Reply-To: <CAH6eHdS8FGdJarwEd+R-hU4Mr8PPY-+OLp5WROP3kEwBMP8nnw@mail.gmail.com> (message from Jonathan Wakely on Sun, 30 Jan 2022 18:06:28 +0100)
> From: Jonathan Wakely <jwakely.gcc@gmail.com>
> Date: Sun, 30 Jan 2022 18:06:28 +0100
> On Sun, 30 Jan 2022 at 16:54, Hans-Peter Nilsson <hp@axis.com> wrote:
> > > From: Jonathan Wakely <jwakely.gcc@gmail.com>
> > > But there is nothing target-specific in that code, so it
> > > should be fine to disable them for simulators. They're
> > > already disabled for LP64 because overflowing the 64-bit
> > > counter would take forever.
> > >
> > > I think that would be better than letting them potentially
> > > run for 40 minutes even on real hardware.
> >
> > Ok. Then this becomes obvious (except from the dejagnu
> > syntax, but that has an obvious progress path). Also tested
> > that it still doesn't run nor gets some dejagnu error on
> > native x86_64-linux-gnu.
> >
> > Committed.
>
> Thanks!
No reason, but thank *you* for the review and for the
biggest time win in test-cycle ever. No, I didn't look, but
7% (720s*2)/5.5h - the total time; surely is unbeatable.
brgds, H-P
prev parent reply other threads:[~2022-01-30 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 1:35 [PATCH] libstdc++ testsuite: Increase lwg3464.cc timeout factors " Hans-Peter Nilsson
2022-01-30 8:32 ` Jonathan Wakely
2022-01-30 16:54 ` [PATCH] libstdc++ testsuite: Don't run lwg3464.cc tests on simulators " Hans-Peter Nilsson
2022-01-30 17:06 ` Jonathan Wakely
2022-01-30 18:05 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220130180519.AE8EB2041A@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).