public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [committed][libgomp, testsuite] Reduce recursion depth in declare_target-*.f90
@ 2022-02-01  7:20 Tom de Vries
  2022-02-01  8:14 ` Jakub Jelinek
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2022-02-01  7:20 UTC (permalink / raw)
  To: gcc-patches; +Cc: Jakub Jelinek

Hi,

When running the libgomp testsuite with GOMP_NVPTX_JIT=-O0 using an nvptx
accelerator (Nvidia T400, 2GB), I run into:
...
libgomp: cuCtxSynchronize error: unspecified launch failure \
  (perhaps abort was called)

libgomp: cuMemFree_v2 error: unspecified launch failure

libgomp: device finalization failed
FAIL: libgomp.fortran/examples-4/declare_target-1.f90   -O0  execution test
...

The test-case contains:
...
  ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
  ! Nvidia Titan V.
  if (fib (23) /= fib_wrapper (23)) stop 2
...

Fix this by reducing the fib/fib_wrapper argument from 23 to 22.

Same for declare_target-2.f90.

Tested on x86_64 with nvptx accelerator.

Committed to trunk.

Thanks,
- Tom

[libgomp, testsuite] Reduce recursion depth in declare_target-*.f90

libgomp/ChangeLog:

2022-01-27  Tom de Vries  <tdevries@suse.de>

	* testsuite/libgomp.fortran/examples-4/declare_target-1.f90: Reduce
	recursion depth.
	* testsuite/libgomp.fortran/examples-4/declare_target-2.f90: Same.

---
 libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90 | 4 +++-
 libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90 | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
index e439fe1b738..b761979ecde 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
@@ -29,5 +29,7 @@ program e_53_1
   if (fib (15) /= fib_wrapper (15)) stop 1
   ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
   ! Nvidia Titan V.
-  if (fib (23) /= fib_wrapper (23)) stop 2
+  ! Reduced from 23 to 22, otherwise execution runs out of thread stack on
+  ! Nvidia T400 (2GB variant), when run with GOMP_NVPTX_JIT=-O0.
+  if (fib (22) /= fib_wrapper (22)) stop 2
 end program
diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
index ee582b21632..f576c25ba39 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
@@ -6,9 +6,11 @@ program e_53_2
   !$omp target map(from: x)
     ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
     ! Nvidia Titan V.
-    x = fib (23)
+    ! Reduced from 23 to 22, otherwise execution runs out of thread stack on
+    ! Nvidia T400 (2GB variant), when run with GOMP_NVPTX_JIT=-O0.
+    x = fib (22)
   !$omp end target
-  if (x /= fib (23)) stop 1
+  if (x /= fib (22)) stop 1
 end program
 
 integer recursive function fib (n) result (f)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [committed][libgomp, testsuite] Reduce recursion depth in declare_target-*.f90
  2022-02-01  7:20 [committed][libgomp, testsuite] Reduce recursion depth in declare_target-*.f90 Tom de Vries
@ 2022-02-01  8:14 ` Jakub Jelinek
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2022-02-01  8:14 UTC (permalink / raw)
  To: Tom de Vries; +Cc: gcc-patches

On Tue, Feb 01, 2022 at 08:20:39AM +0100, Tom de Vries wrote:
> [libgomp, testsuite] Reduce recursion depth in declare_target-*.f90
> 
> libgomp/ChangeLog:
> 
> 2022-01-27  Tom de Vries  <tdevries@suse.de>
> 
> 	* testsuite/libgomp.fortran/examples-4/declare_target-1.f90: Reduce
> 	recursion depth.
> 	* testsuite/libgomp.fortran/examples-4/declare_target-2.f90: Same.

Ok.

	Jakub


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-01  8:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01  7:20 [committed][libgomp, testsuite] Reduce recursion depth in declare_target-*.f90 Tom de Vries
2022-02-01  8:14 ` Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).