From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 32FC53858437 for ; Tue, 1 Feb 2022 23:02:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32FC53858437 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 211N1bjg017355; Tue, 1 Feb 2022 17:01:37 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 211N1b2Y017354; Tue, 1 Feb 2022 17:01:37 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 1 Feb 2022 17:01:36 -0600 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH 5/8] rs6000: Fix LE code gen for vec_cnt[lt]z_lsbb [PR95082] Message-ID: <20220201230136.GX614@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 23:02:39 -0000 On Fri, Jan 28, 2022 at 11:50:23AM -0600, Bill Schmidt wrote: > These built-ins were misimplemented as always having big-endian semantics. > PR target/95082 > * config/rs6000/rs6000-builtin.cc (rs6000_expand_builtin): Handle > endianness for vclzlsbb and vctzlsbb. > * config/rs6000/rs6000-builtins.def (VCLZLSBB_V16QI): Change > default pattern and indicate a different pattern will be used for > big endian. > (VCLZLSBB_V4SI): Likewise. > (VCLZLSBB_V8HI): Likewise. > (VCTZLSBB_V16QI): Likewise. > (VCTZLSBB_V4SI): Likewise. > (VCTZLSBB_V8HI): Likewise. Please don't break lines early? Changelog lines are one tab followed by 72 chars. The patch is fine though. Thanks! Segher