From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DFF4E3858D20 for ; Fri, 4 Feb 2022 13:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DFF4E3858D20 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-Mv90qNxSPSWYdMGg146Szw-1; Fri, 04 Feb 2022 08:30:25 -0500 X-MC-Unique: Mv90qNxSPSWYdMGg146Szw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FCCA100C609; Fri, 4 Feb 2022 13:30:24 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 652AA22DF1; Fri, 4 Feb 2022 13:30:23 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 214DUKak133132 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 4 Feb 2022 14:30:20 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 214DUId5133131; Fri, 4 Feb 2022 14:30:18 +0100 Date: Fri, 4 Feb 2022 14:30:18 +0100 From: Jakub Jelinek To: Richard Biener Cc: Rainer Orth , GCC Patches Subject: Re: [PATCH] configure: add --disable-fix-includes Message-ID: <20220204133018.GD2646553@tucnak> Reply-To: Jakub Jelinek References: <417eca08-e1ad-538e-c39a-388e20e2fcca@suse.cz> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 13:30:31 -0000 On Fri, Feb 04, 2022 at 02:25:17PM +0100, Richard Biener via Gcc-patches wrote: > > Besides, have you actually run a regtest with that option? I'm asking > > because even on Ubuntu 20.04 fixincludes drops in it's own . > > You need to check that dropping that is actually safe. > > limits.h and syslimits.h are the only include-fixed we "ship" in our > packages. Not sure if they are really required though. We don't ship any include-fixed headers in Fedora/RHEL. If there is an important need for fixing, it should be in Linux distributions fixed by actually fixing the headers in their corresponding packages, making modified copies of headers at gcc build time and overriding through that headers from other packages that can change doesn't really work properly when those headers ever change. I know we could install the fixincludes tool and trigger running it whenever any of such headers change in other packages, but that is very expensive for very little gain. On other targets I understand fixincludes is much more important. Jakub