public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] combine: Fix up -fcompare-debug issue in the combiner [PR104544]
Date: Wed, 16 Feb 2022 09:11:52 -0600	[thread overview]
Message-ID: <20220216151152.GI614@gate.crashing.org> (raw)
In-Reply-To: <20220216105523.GY2646553@tucnak>

On Wed, Feb 16, 2022 at 11:55:23AM +0100, Jakub Jelinek wrote:
> On Wed, Feb 16, 2022 at 04:44:58AM -0600, Segher Boessenkool wrote:
> > About half of the similar loops in combine.c are still broken this way,
> > from a quick sampling :-(
> 
> Looking for just NONDEBUG_INSN_P, I don't see any other than this.

Ah yes, I was confused by !NONDEBUG_INSN.  Too many inversions make my
head spin (NONDEBUG_INSN really means RTX_INSN && !DEBUG_INSN).

So everything looks fine here now.  Thanks for double checking!


Segher

      reply	other threads:[~2022-02-16 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  8:53 Jakub Jelinek
2022-02-16 10:44 ` Segher Boessenkool
2022-02-16 10:55   ` Jakub Jelinek
2022-02-16 15:11     ` Segher Boessenkool [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216151152.GI614@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).