From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH 4/4] Allow vsx_extract_<mode> to use Altivec registers, PR target/99293
Date: Mon, 28 Mar 2022 18:59:14 -0500 [thread overview]
Message-ID: <20220328235914.GQ614@gate.crashing.org> (raw)
In-Reply-To: <YkHiR3hZQ2LCnEpE@toto.the-meissners.org>
On Mon, Mar 28, 2022 at 12:28:55PM -0400, Michael Meissner wrote:
> In looking at PR target/99293, I noticed that the vsx_extract_<mode>
> pattern for V2DImode and V2DFmode only allowed traditional floating point
> registers, and it did not allow Altivec registers. The original code was
> written a few years ago when we used the old register allocator, and
> support for scalar floating point in Altivec registers was just being
> added to GCC.
vsx_extract_<mode> is from 2009... How time flies :-)
This comment is from 2016 though. Still before LRA was default for us
of course ;-)
If would have been nice if we had a testcase for this breakage, so that
we could now be confident it really has been fixed. But the "reload"
here likely means "old reload", so okay.
> PR target/99293
It has essentially nothing to do with that PR, right? Or I just do not
see it, always a possibility of course.
> * config/rs6000/rs6000.md (vsx_extract_<mode>): Allow destination
> to be an Altivec register.
... to be any VSX register.
Okay for trunk with those things fixed. Thanks!
Segher
next prev parent reply other threads:[~2022-03-29 0:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 16:24 [PATCH 0/4] Optimize vec_splats of vec_extract, " Michael Meissner
2022-03-28 16:26 ` [PATCH 1/4] Optimize vec_splats of constant vec_extract for V2DI/V2DF, PR target 99293 Michael Meissner
2022-03-28 17:14 ` Segher Boessenkool
2022-03-28 22:30 ` Michael Meissner
2022-03-28 23:25 ` Segher Boessenkool
2022-03-28 16:27 ` [PATCH 2/4] Make vsx_splat_<mode>_reg use correct insn attributes, PR target/99293 Michael Meissner
2022-03-28 20:28 ` Segher Boessenkool
2022-03-30 22:41 ` Michael Meissner
2022-04-01 17:21 ` Segher Boessenkool
2022-03-28 16:28 ` [PATCH 3/4] Make vsx_extract_<mode> use correct insn attributes, PR target 99293 Michael Meissner
2022-03-28 22:06 ` Segher Boessenkool
2022-03-30 22:58 ` Michael Meissner
2022-03-28 16:28 ` [PATCH 4/4] Allow vsx_extract_<mode> to use Altivec registers, PR target/99293 Michael Meissner
2022-03-28 23:59 ` Segher Boessenkool [this message]
2022-03-29 17:26 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328235914.GQ614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).