From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>,
ebotcazou@gcc.gnu.org
Subject: Re: [PATCH] Disable float128 tests on VxWorks, PR target/104253.
Date: Thu, 7 Apr 2022 06:00:51 -0500 [thread overview]
Message-ID: <20220407110051.GL614@gate.crashing.org> (raw)
In-Reply-To: <Yk5ouVh7fw09nXLK@toto.the-meissners.org>
On Thu, Apr 07, 2022 at 12:29:45AM -0400, Michael Meissner wrote:
> In PR target/104253, it was pointed out the that test case added as part
> of fixing the PR does not work on VxWorks because float128 is not
> supported on that system. I have modified the three tests for float128 so
> that they are manually excluded on VxWorks systems. In looking at the
> code, I also added checks in check_effective_target_ppc_ieee128_ok to
> disable the systems that will never support VSX instructions which are
> required for float128 support (eabi, eabispe, darwin).
It's just one extra to the big list here, but, why do we need all these
manual exclusions anyway? What is broken about the test itself?
It would be so much more useful if the tests would help us, instead of
producing a lot of extra busy-work.
Segher
next prev parent reply other threads:[~2022-04-07 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 4:29 Michael Meissner
2022-04-07 10:47 ` Eric Botcazou
2022-04-07 19:00 ` Michael Meissner
2022-04-07 11:00 ` Segher Boessenkool [this message]
2022-04-07 13:50 ` will schmidt
2022-04-07 15:05 ` Segher Boessenkool
2022-04-07 18:59 ` Michael Meissner
2022-04-07 20:17 ` Segher Boessenkool
2022-04-07 22:29 ` Committed: " Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407110051.GL614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=ebotcazou@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).