From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id D8A533858C50; Thu, 7 Apr 2022 20:18:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8A533858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 237KHKTH013637; Thu, 7 Apr 2022 15:17:20 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 237KHJJr013636; Thu, 7 Apr 2022 15:17:19 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 7 Apr 2022 15:17:19 -0500 From: Segher Boessenkool To: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner , Will Schmidt , ebotcazou@gcc.gnu.org Subject: Re: [PATCH] Disable float128 tests on VxWorks, PR target/104253. Message-ID: <20220407201719.GP614@gate.crashing.org> References: <20220407110051.GL614@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 20:18:22 -0000 Hi! On Thu, Apr 07, 2022 at 02:59:55PM -0400, Michael Meissner wrote: > On Thu, Apr 07, 2022 at 06:00:51AM -0500, Segher Boessenkool wrote: > > On Thu, Apr 07, 2022 at 12:29:45AM -0400, Michael Meissner wrote: > > > In PR target/104253, it was pointed out the that test case added as part > > > of fixing the PR does not work on VxWorks because float128 is not > > > supported on that system. I have modified the three tests for float128 so > > > that they are manually excluded on VxWorks systems. In looking at the > > > code, I also added checks in check_effective_target_ppc_ieee128_ok to > > > disable the systems that will never support VSX instructions which are > > > required for float128 support (eabi, eabispe, darwin). > > > > It's just one extra to the big list here, but, why do we need all these > > manual exclusions anyway? What is broken about the test itself? > > > > It would be so much more useful if the tests would help us, instead of > > producing a lot of extra busy-work. > > Those lines were copied from other lines in the power7 era, and have just been > copied since then. And never updated or given any (second) thought :-( > I agree it is perhaps time to remove these in GCC 13, but I > would be hesitant to remove them now. I can not put in the eabi, eabispe and > darwin lines in check_effective_target_ppc_ieee128_ok, and just add the > vsxworks lines. What I want to see is the tests (in target-supports) to just work, without manual intervention for targets that are even mildly interesting :-( (Btw, powerpc*-*-eabi* would be simpler, more compact, and more correct here!) > With these changes can I check these in and then do a backport later? Eric already approved it. It is fine with me of course, but I do want things to get better eventually! Segher