From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 14BA73858C54 for ; Tue, 12 Apr 2022 19:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14BA73858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 23CJBOUK020869; Tue, 12 Apr 2022 14:11:24 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 23CJBNIs020868; Tue, 12 Apr 2022 14:11:23 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 12 Apr 2022 14:11:23 -0500 From: Segher Boessenkool To: "Kewen.Lin" Cc: Jakub Jelinek , Bill Schmidt , Peter Bergner , GCC Patches , David Edelsohn Subject: Re: [PATCH] rs6000: Guard bifs {un, }pack_{longdouble, ibm128} under hard float [PR103623] Message-ID: <20220412191123.GF614@gate.crashing.org> References: <20220407110952.GM614@gate.crashing.org> <20220408173105.GU614@gate.crashing.org> <31b02ece-83e3-f940-8898-c0a9c19c38bd@linux.ibm.com> <20220411154214.GW614@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Apr 2022 19:12:26 -0000 On Tue, Apr 12, 2022 at 10:02:06AM +0800, Kewen.Lin wrote: > on 2022/4/11 11:42 PM, Segher Boessenkool wrote: > > On Mon, Apr 11, 2022 at 04:29:40PM +0800, Kewen.Lin wrote: > >> Nice, I confirmed this makes ICE gone, I've filed one new PR > >> PR105213 for GCC13 further tracking by associating this patch there. > > > > Cool, I'll commit it later today then (after a final regstrap). The > > _nodm pattern just missed the alternative for no FP regs (the _dm > > pattern has it, so just an oversight). > > Thanks! So it can be counted as a regression fix instead of tiny > feature work? Maybe we also need bif documentation change, and > gcc12 changes html update (as bif behavior changes), or it's > too small so no? It is just a bugfix. Everything in anything that is not a new feature is arguably a regression fix, so that classification isn't useful normally. I'd rather fix more bugs than do more filing work ;-) The documentation already has this under "The following built-in functions are also available on all PowerPC processors:", so no doc changes are needed either: this is a bugfix! :-) Segher