From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 134543858D28 for ; Mon, 25 Apr 2022 21:35:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 134543858D28 Received: by mail-ed1-x534.google.com with SMTP id k27so4859896edk.4 for ; Mon, 25 Apr 2022 14:35:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z0V2aiwWKVZAPdjeO8+A41842STBcW7f4UOUaqeedw0=; b=249f+V28ZKEClJsRyGIT8PAZVFslSrWziboWNjw5CWRahYUa31Bwbszy6Y2XWwEKEb Y6WmkgZ6qn5H//MaKECB7oG4juNM64gqmaYxKaoksXCzuAYQqa8/+1mJSTkEJptWnUyL HbBL9ET1v4Se8EgsO4h2OSEIyhbF9/smFLyrvy31SFDzJ8OhlgXUs1X6e1egJkHWv/x9 hIMTSI//+seRs1OkI3mCkVHSEfaucCPmQ9uxeYYO41zVeSgewpT/QnoO7NfZS1BtNJce JhLzpuP1XjJIXb0E7SO2yuoPmpCg32VgwSntxzGo68c1okiqq3MmaGFdjNXmeETn4IZ3 CxnA== X-Gm-Message-State: AOAM533G3Hs7/+8aIaY0MOTJ6+XrheS+WT3BKpNuIHhpYGxO41Pyypyi f7fExu0EHIchDPkw3Zkl8ug= X-Google-Smtp-Source: ABdhPJzh3FRmu69ip4RXNT6+8m6omZZssxJ9fPI/urvSDoFAGXu99ofXH/li7EO5uWOsQA1Ar2xAUw== X-Received: by 2002:a05:6402:cac:b0:410:a920:4e90 with SMTP id cn12-20020a0564020cac00b00410a9204e90mr21163118edb.60.1650922500696; Mon, 25 Apr 2022 14:35:00 -0700 (PDT) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id he37-20020a1709073da500b006f38517dccesm2327614ejc.208.2022.04.25.14.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 14:35:00 -0700 (PDT) Date: Mon, 25 Apr 2022 23:34:57 +0200 From: Bernhard Reutner-Fischer To: Mike Stump Cc: rep.dot.nop@gmail.com, Uros Bizjak , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, testsuite]: Cleanup dumps Message-ID: <20220425233457.4879165b@nbbrfq> In-Reply-To: References: <7B4175B2-2FAA-4A96-943B-06B379D03C75@gmail.com> <4420E8FB-D61F-4F61-8A86-6ADE01B235E9@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 21:35:03 -0000 On Fri, 29 May 2015 10:44:02 +0200 Bernhard Reutner-Fischer wrote: > On 29 May 2015 at 10:21, Bernhard Reutner-Fischer = wrote: > > On 31 January 2015 at 22:10, Bernhard Reutner-Fischer > > wrote: =20 > >> On January 31, 2015 9:17:57 PM GMT+01:00, Mike Stump wrote: =20 >=20 > >>>If you want to wait until stage 1, that=E2=80=99s fine too. =20 > >> > >> I'd only want that to go in in stage 1. =20 > > > > I have applied this now as r223858. > > Please CC me on fallout. =20 >=20 >=20 > To recap: >=20 > The idea is to automatically delete dump-files in the testsuite > instead of annotating alot of testcases in their dg-final. >=20 > To quote sourcebuild.texi, "Clean up generated test files": > --- 8< --- > Usually the test-framework removes files that were generated during > testing. If a testcase, for example, uses any dumping mechanism to > inspect a passes dump file, the testsuite recognized the dumping option > passed to the tool and schedules a final cleanup to remove these files. > --- 8< --- >=20 > The following TCL procs were deleted from the test framework and > CANNOT be used anymore in dg-final: > - cleanup-ipa-dump > - cleanup-rtl-dump > - cleanup-tree-dump > - cleanup-saved-temps >=20 > These dump-files are now automatically deleted in the testsuite, via a > schedule-cleanups in some basic .exp helpers. >=20 > Just delete any // dg-final { cleanup-see-above-list } > from your new testcases. >=20 >=20 > The .plan is to gradually do the same for the remaining dumps like > stack etc. See remaining parts in sourcebuild.texi and this comment in > schedule-cleanups: > + # TODO > + # -fprofile-generate -> cleanup-coverage-files() > + # -fstack-usage -> cleanup-stack-usage() >=20 > Mike, just so i do not forget: >=20 > I have retained the cleanup-saved-temps proc for now since it's used in l= to.exp. > I want to rename it later on to prevent people from using it in their > dg-final since this is now done automatically. >=20 > cheers, Hi! Some time later now. We're in gcc-12 stage 4. The automatic cleanup handling was quite successful i think. I.e. folks did not have to waste any noteworthy time on manual cleanup hunting ever since then AFAIK. So.. Iff you find leftovers in the testsuite in gcc-12 or 11 onwards from running tests, then please let us know. And if you are willing to delve into removing the tcl leftovers from way back, or if you have time to apply some more TLC to the cleanup handling itself or if you see opportunity to cleanup the cleanup handling itself, then please do so. IIRC there are a few bits left that one could handle automatically, if deemed generally useful and if you have spare time. PS: $ git grep dg-final gcc/testsuite/ | egrep -v "(ChangeLog| scan-)" | sed -e= 's/.*dg-final //' -e 's/\s*{\s*//' -e 's/}/ /g' | awk '{print $1}' | sort = | uniq -c | sort -nr -k1 2697 check-function-bodies 486 gdb-test 62 run-gcov 34 scan-assembler-times 25 cleanup-ada-spec 23 simulate-thread 22 object-size ... PS: gcc/testsuite/lib/scanasm.exp: object-size is under-used. We should have way more size tests. And we should have size tests that aim to regain the regressions that came with the SSA merge ;) thanks,