[PATCH] testsuite: Make AArch64 attributes_7.c generate unique report lines.

[PATCH] testsuite: Make AArch64 attributes_7.c generate unique report lines.

[Christophe Lyon]

This test is executed in both C and C++ modes, lines 98 and 100 pass
in C++ and are xfail in C.

This results in similar lines in gcc.sum and g++.sum, differing by the
PASS or XFAIL prefix, which confuses compare_test: it reports these
tests twice, as "now fail, but worked before" and "now work, but
didn't before". To make the diagnostic different betweek C and C++, I
use $tool in the dg-error comment field.

2022-05-06  Christophe Lyon  <christophe.lyon@arm.com>

	gcc/testsuite/
	* gcc.target/aarch64/sve/acle/general/attributes_7.c: Make
	diagnostic unique.
---
 .../gcc.target/aarch64/sve/acle/general/attributes_7.c        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
index 621666ce6c9..95be60591fb 100644
--- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
+++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
@@ -95,9 +95,9 @@ f (int c)
   fb = sb;
 
   (void) (c ? sb : sb);
-  (void) (c ? sb : fb); // { dg-error {type mismatch|different types} "" { xfail c } }
+  (void) (c ? sb : fb); // { dg-error {type mismatch|different types} "$tool" { xfail c } }
 
-  (void) (c ? fb : sb); // { dg-error {type mismatch|different types} "" { xfail c } }
+  (void) (c ? fb : sb); // { dg-error {type mismatch|different types} "$tool" { xfail c } }
   (void) (c ? fb : fb);
 }
 
-- 
2.25.1

Re: [PATCH] testsuite: Make AArch64 attributes_7.c generate unique report lines.

[Richard Sandiford]

Christophe Lyon via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> This test is executed in both C and C++ modes, lines 98 and 100 pass
> in C++ and are xfail in C.
>
> This results in similar lines in gcc.sum and g++.sum, differing by the
> PASS or XFAIL prefix, which confuses compare_test: it reports these
> tests twice, as "now fail, but worked before" and "now work, but
> didn't before". To make the diagnostic different betweek C and C++, I
> use $tool in the dg-error comment field.
>
> 2022-05-06  Christophe Lyon  <christophe.lyon@arm.com>
>
> 	gcc/testsuite/
> 	* gcc.target/aarch64/sve/acle/general/attributes_7.c: Make
> 	diagnostic unique.

OK, thanks.

Richard

> ---
>  .../gcc.target/aarch64/sve/acle/general/attributes_7.c        | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
> index 621666ce6c9..95be60591fb 100644
> --- a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
> +++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/attributes_7.c
> @@ -95,9 +95,9 @@ f (int c)
>    fb = sb;
>  
>    (void) (c ? sb : sb);
> -  (void) (c ? sb : fb); // { dg-error {type mismatch|different types} "" { xfail c } }
> +  (void) (c ? sb : fb); // { dg-error {type mismatch|different types} "$tool" { xfail c } }
>  
> -  (void) (c ? fb : sb); // { dg-error {type mismatch|different types} "" { xfail c } }
> +  (void) (c ? fb : sb); // { dg-error {type mismatch|different types} "$tool" { xfail c } }
>    (void) (c ? fb : fb);
>  }