From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Eric Botcazou <ebotcazou@adacore.com>
Subject: [Ada] Fix for internal error on semi-circular record aggregate
Date: Thu, 19 May 2022 14:16:21 +0000 [thread overview]
Message-ID: <20220519141621.GA3723495@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
This creates a couple of record subtypes pointing to each other through
access subtypes, and we break the circularity at the latter subtypes.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* gcc-interface/decl.cc (gnat_to_gnu_entity) <E_Record_Subtype>: If
it is a special subtype designated by an access subtype, then defer
the completion of incomplete types.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1548 bytes --]
diff --git a/gcc/ada/gcc-interface/decl.cc b/gcc/ada/gcc-interface/decl.cc
--- a/gcc/ada/gcc-interface/decl.cc
+++ b/gcc/ada/gcc-interface/decl.cc
@@ -2134,6 +2134,8 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
suppress expanding incomplete types. */
gnu_type = make_node (UNCONSTRAINED_ARRAY_TYPE);
+ /* The component may refer to this type, so defer completion of any
+ incomplete types. */
if (!definition)
{
defer_incomplete_level++;
@@ -3066,7 +3068,8 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
process_attributes (&gnu_type, &attr_list, true, gnat_entity);
- /* If we are not defining it, suppress expanding incomplete types. */
+ /* Some component may refer to this type, so defer completion of any
+ incomplete types. */
if (!definition)
{
defer_incomplete_level++;
@@ -3439,7 +3442,14 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
{
Entity_Id gnat_base_type = Implementation_Base_Type (gnat_entity);
- if (!definition)
+ /* Some component may refer to this type, so defer completion of any
+ incomplete types. We also need to do it for the special subtypes
+ designated by access subtypes in case they are recursive, see the
+ E_Access_Subtype case below. */
+ if (!definition
+ || (Is_Itype (gnat_entity)
+ && Is_Frozen (gnat_entity)
+ && No (Freeze_Node (gnat_entity))))
{
defer_incomplete_level++;
this_deferred = true;
reply other threads:[~2022-05-19 14:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519141621.GA3723495@adacore.com \
--to=derodat@adacore.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).