From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 542AE382D50F for ; Fri, 27 May 2022 02:36:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 542AE382D50F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x42e.google.com with SMTP id p8so3213248pfh.8 for ; Thu, 26 May 2022 19:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3q9Al2rh6nAr9tb053rNx2d02UCqLfwTgt6UvSQgBJA=; b=TIw3tGrGZQbaSMZTsUnA1trAvJygHQNBIse74piEanoHJIGr0zG33u7y4qRPpgh9CF RfLmRGX7P5lCsMhYdy5B6rvDXBWDjBwFbKpapOy0g7OQ2joUCD/Df5lQGmh1vwP4PmHz b9W6Eef2yd9c7DBoOj9IyC5IMBEplulosj+5r7WpMVFHRCtvBchVYMpfAFY9byjsolrw Kd/lbZZEYX6C6adWqu3QVHrqoEm4CUPZn4C4yNFACYG3xtCWzLwCKqLj5QN9N7dswl17 qkrBoQUb4fZ6+wBSkjC++hm6nFny/sr5uipGvVNPY1kKbn63tP6vPscR6ZwIJRWvle9n GlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3q9Al2rh6nAr9tb053rNx2d02UCqLfwTgt6UvSQgBJA=; b=DWwEFYRrqYxruNwhVAhnOEKFUm2oY+QFWHW88YTpZZc0nwzDThoXV52OLe91ZDxsQm KrCx6WRJt23o7BTBKjvZ49PXz8LmRQgn66iOF/dKdCiiguP6XpmcaKejBdsqzTcf03dS wRC2oayUo8xxl6tmqvFNPdGvdmbWXt6fSnAUCn0Rtd65tM3+0y9FW09N9FHgLyXB1PSt tSkw9NAxS54M+5euaVYWpkts85nyu9RrhVwHpXdYVt9sqOU4m0CGnb3OQ0rMcNnJ6Vb1 fjRVUhTcO9/JcZvoNZa98O9/paXkV8q3a6yCbT/H3RnNK/BIaNylMAdbDhqjcR1xfjVP Yg9w== X-Gm-Message-State: AOAM5316fRCwMZWP5wfJEKSy0FEkC4p5cgLQ1sz27Wk7sVQxQ4I1xVLX pyfnJ+hwpKDnDeH/L0+m1nGF6HPhB9sP6c2f X-Google-Smtp-Source: ABdhPJx0D8mXIRjp6jMjpaPaDhMBgZdcXF2swuvolrFd1b4bFxSUa1GTiwEdP7saJo2M5T4x4d+L4Q== X-Received: by 2002:a63:f646:0:b0:3db:7288:9ab5 with SMTP id u6-20020a63f646000000b003db72889ab5mr35166956pgj.290.1653619001018; Thu, 26 May 2022 19:36:41 -0700 (PDT) Received: from vineetg-framework.ba.rivosinc.com (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id h6-20020a636c06000000b003c619f3d086sm2246189pgc.2.2022.05.26.19.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 19:36:40 -0700 (PDT) From: Vineet Gupta To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Philipp Tomsich , Palmer Dabbelt , =?UTF-8?q?Christoph=20M=C3=BCllner?= , gnu-toolchain@rivosinc.com, Andrew Waterman , "Maciej W . Rozycki" , Vineet Gupta Subject: [PATCH v3] RISC-V/testsuite: constraint some of tests to hard_float Date: Thu, 26 May 2022 19:36:36 -0700 Message-Id: <20220527023636.2224696-1-vineetg@rivosinc.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220527015646.2220532-1-vineetg@rivosinc.com> References: <20220527015646.2220532-1-vineetg@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 02:36:44 -0000 Commit 9ddd44b58649d1d ("RISC-V: Provide `fmin'/`fmax' RTL pattern") added tests which check for hard float instructions which obviously fails on soft-float ABI builds. And my recent commit b646d7d279ae ("RISC-V: Inhibit FP <--> int register moves via tune param") is guilty of same crime. So constraint with "dg-require-effective-target hard_float" This reduces bunch of new RV failures. | ========= Summary of gcc testsuite ========= | | # of unexpected case / # of unique unexpected case | | gcc | g++ | gfortran | | rv64imac/ lp64/ medlow | 134 / 22 | 0 / 0 | - | BEFORE | rv64imac/ lp64/ medlow | 22 / 9 | 0 / 0 | - | AFTER | gcc/testsuite/Changelog: * gcc.target/riscv/fmax.c: Add dg-require-effective-target hard_float. * gcc.target/riscv/fmaxf.c: Ditto. * gcc.target/riscv/fmin.c: Ditto. * gcc.target/riscv/fminf.c: Ditto. * gcc.target/riscv/smax-ieee.c: Ditto. * gcc.target/riscv/smax.c: Ditto. * gcc.target/riscv/smaxf-ieee.c: Ditto. * gcc.target/riscv/smaxf.c: Ditto. * gcc.target/riscv/smin-ieee.c: Ditto. * gcc.target/riscv/smin.c: Ditto. * gcc.target/riscv/sminf-ieee.c: Ditto. * gcc.target/riscv/sminf.c: Ditto. * gcc.target/riscv/pr105666.c: Ditto. Signed-off-by: Vineet Gupta --- v3: Added fix to pr105666.c as well. v2: Fixed the SoB snafu in v1 --- gcc/testsuite/gcc.target/riscv/fmax.c | 1 + gcc/testsuite/gcc.target/riscv/fmaxf.c | 1 + gcc/testsuite/gcc.target/riscv/fmin.c | 1 + gcc/testsuite/gcc.target/riscv/fminf.c | 1 + gcc/testsuite/gcc.target/riscv/pr105666.c | 1 + gcc/testsuite/gcc.target/riscv/smax-ieee.c | 1 + gcc/testsuite/gcc.target/riscv/smax.c | 1 + gcc/testsuite/gcc.target/riscv/smaxf-ieee.c | 1 + gcc/testsuite/gcc.target/riscv/smaxf.c | 1 + gcc/testsuite/gcc.target/riscv/smin-ieee.c | 1 + gcc/testsuite/gcc.target/riscv/smin.c | 1 + gcc/testsuite/gcc.target/riscv/sminf-ieee.c | 1 + gcc/testsuite/gcc.target/riscv/sminf.c | 1 + 13 files changed, 13 insertions(+) diff --git a/gcc/testsuite/gcc.target/riscv/fmax.c b/gcc/testsuite/gcc.target/riscv/fmax.c index c71d35c9f9dc..e1b7fa8f918c 100644 --- a/gcc/testsuite/gcc.target/riscv/fmax.c +++ b/gcc/testsuite/gcc.target/riscv/fmax.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/fmaxf.c b/gcc/testsuite/gcc.target/riscv/fmaxf.c index f9980166887a..8da0513dc8f6 100644 --- a/gcc/testsuite/gcc.target/riscv/fmaxf.c +++ b/gcc/testsuite/gcc.target/riscv/fmaxf.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ float diff --git a/gcc/testsuite/gcc.target/riscv/fmin.c b/gcc/testsuite/gcc.target/riscv/fmin.c index 9634abd19af8..01993d49bc21 100644 --- a/gcc/testsuite/gcc.target/riscv/fmin.c +++ b/gcc/testsuite/gcc.target/riscv/fmin.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/fminf.c b/gcc/testsuite/gcc.target/riscv/fminf.c index 9a3687be3092..32ce363e10d8 100644 --- a/gcc/testsuite/gcc.target/riscv/fminf.c +++ b/gcc/testsuite/gcc.target/riscv/fminf.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ float diff --git a/gcc/testsuite/gcc.target/riscv/pr105666.c b/gcc/testsuite/gcc.target/riscv/pr105666.c index 904f3bc0763f..dd996eec8efc 100644 --- a/gcc/testsuite/gcc.target/riscv/pr105666.c +++ b/gcc/testsuite/gcc.target/riscv/pr105666.c @@ -6,6 +6,7 @@ spilling to stack. */ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-march=rv64g -ffast-math" } */ #define NITER 4 diff --git a/gcc/testsuite/gcc.target/riscv/smax-ieee.c b/gcc/testsuite/gcc.target/riscv/smax-ieee.c index 3a98aeb45add..2dbccefe2f4d 100644 --- a/gcc/testsuite/gcc.target/riscv/smax-ieee.c +++ b/gcc/testsuite/gcc.target/riscv/smax-ieee.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/smax.c b/gcc/testsuite/gcc.target/riscv/smax.c index d806c632faed..1092cc49f25e 100644 --- a/gcc/testsuite/gcc.target/riscv/smax.c +++ b/gcc/testsuite/gcc.target/riscv/smax.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c index 6cf23d789b6e..31b9bfa4d91e 100644 --- a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c +++ b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ float diff --git a/gcc/testsuite/gcc.target/riscv/smaxf.c b/gcc/testsuite/gcc.target/riscv/smaxf.c index d6a7a7f84cf7..aa1f22b45a17 100644 --- a/gcc/testsuite/gcc.target/riscv/smaxf.c +++ b/gcc/testsuite/gcc.target/riscv/smaxf.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ float diff --git a/gcc/testsuite/gcc.target/riscv/smin-ieee.c b/gcc/testsuite/gcc.target/riscv/smin-ieee.c index c0a148c37cf1..ea36c2de89fe 100644 --- a/gcc/testsuite/gcc.target/riscv/smin-ieee.c +++ b/gcc/testsuite/gcc.target/riscv/smin-ieee.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/smin.c b/gcc/testsuite/gcc.target/riscv/smin.c index e325e9a1c7cc..d07a0fdc1525 100644 --- a/gcc/testsuite/gcc.target/riscv/smin.c +++ b/gcc/testsuite/gcc.target/riscv/smin.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ double diff --git a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c index 353e7a18704a..427617af08f1 100644 --- a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c +++ b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ float diff --git a/gcc/testsuite/gcc.target/riscv/sminf.c b/gcc/testsuite/gcc.target/riscv/sminf.c index f0ba7b43bdf9..7df223e8bcad 100644 --- a/gcc/testsuite/gcc.target/riscv/sminf.c +++ b/gcc/testsuite/gcc.target/riscv/sminf.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ float -- 2.32.0