From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Fix expansion of structural subprogram variants
Date: Mon, 30 May 2022 08:33:00 +0000 [thread overview]
Message-ID: <20220530083300.GA211053@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
When implementing structural subprogram variants we ignored them in
expansion of the pragma itself, but not in expansion of a recursive
subprogram call. Now fixed.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* exp_ch6.adb (Check_Subprogram_Variant): Ignore structural
variants.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1671 bytes --]
diff --git a/gcc/ada/exp_ch6.adb b/gcc/ada/exp_ch6.adb
--- a/gcc/ada/exp_ch6.adb
+++ b/gcc/ada/exp_ch6.adb
@@ -3298,19 +3298,33 @@ package body Exp_Ch6 is
Variant_Prag : constant Node_Id :=
Get_Pragma (Current_Scope, Pragma_Subprogram_Variant);
+ Pragma_Arg1 : Node_Id;
Variant_Proc : Entity_Id;
begin
if Present (Variant_Prag) and then Is_Checked (Variant_Prag) then
- -- Analysis of the pragma rewrites its argument with a reference
- -- to the internally generated procedure.
+ Pragma_Arg1 :=
+ Expression (First (Pragma_Argument_Associations (Variant_Prag)));
- Variant_Proc :=
- Entity
- (Expression
- (First
- (Pragma_Argument_Associations (Variant_Prag))));
+ -- If pragma parameter is still an aggregate, it comes from a
+ -- structural variant, which is not expanded and ignored for
+ -- run-time execution.
+
+ if Nkind (Pragma_Arg1) = N_Aggregate then
+ pragma Assert
+ (Chars
+ (First
+ (Choices
+ (First (Component_Associations (Pragma_Arg1))))) =
+ Name_Structural);
+ return;
+ end if;
+
+ -- Otherwise, analysis of the pragma rewrites its argument with a
+ -- reference to the internally generated procedure.
+
+ Variant_Proc := Entity (Pragma_Arg1);
Insert_Action (Call_Node,
Make_Procedure_Call_Statement (Loc,
reply other threads:[~2022-05-30 8:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530083300.GA211053@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).