From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Justin Squirek <squirek@adacore.com>
Subject: [Ada] Gnatbind crash during checksum calculation
Date: Thu, 2 Jun 2022 09:08:46 +0000 [thread overview]
Message-ID: <20220602090846.GA1010514@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
This patch corrects an error in the compiler whereby gnatbind may crash
during calculation of file checksums in certain corner cases due to
uninitialized lookup tables.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* gnatbind.adb (Gnatbind): Add initialize call for Uintp
* gnatls.adb (Gnatls): Likewise.
* gprep.adb (Gnatprep): Likewise.
* make.adb (Initialize): Likewise.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1999 bytes --]
diff --git a/gcc/ada/gnatbind.adb b/gcc/ada/gnatbind.adb
--- a/gcc/ada/gnatbind.adb
+++ b/gcc/ada/gnatbind.adb
@@ -50,6 +50,7 @@ with Switch; use Switch;
with Switch.B; use Switch.B;
with Targparm; use Targparm;
with Types; use Types;
+with Uintp;
with System.Case_Util; use System.Case_Util;
with System.Response_File;
@@ -617,6 +618,7 @@ begin
-- is in some cases important.
Csets.Initialize;
+ Uintp.Initialize;
Snames.Initialize;
-- Scan the switches and arguments. Note that Snames must already be
diff --git a/gcc/ada/gnatls.adb b/gcc/ada/gnatls.adb
--- a/gcc/ada/gnatls.adb
+++ b/gcc/ada/gnatls.adb
@@ -44,6 +44,7 @@ with Snames;
with Stringt;
with Switch; use Switch;
with Types; use Types;
+with Uintp;
with GNAT.Case_Util; use GNAT.Case_Util;
with GNAT.Command_Line; use GNAT.Command_Line;
@@ -2023,6 +2024,7 @@ begin
-- Initialize standard packages
Csets.Initialize;
+ Uintp.Initialize;
Snames.Initialize;
Stringt.Initialize;
diff --git a/gcc/ada/gprep.adb b/gcc/ada/gprep.adb
--- a/gcc/ada/gprep.adb
+++ b/gcc/ada/gprep.adb
@@ -37,6 +37,7 @@ with Snames;
with Stringt; use Stringt;
with Switch; use Switch;
with Types; use Types;
+with Uintp;
with Ada.Command_Line; use Ada.Command_Line;
with Ada.Text_IO; use Ada.Text_IO;
@@ -169,6 +170,7 @@ package body GPrep is
-- Do some initializations (order is important here)
Csets.Initialize;
+ Uintp.Initialize;
Snames.Initialize;
Stringt.Initialize;
Prep.Initialize;
diff --git a/gcc/ada/make.adb b/gcc/ada/make.adb
--- a/gcc/ada/make.adb
+++ b/gcc/ada/make.adb
@@ -44,6 +44,7 @@ with SFN_Scan;
with Sinput;
with Snames;
with Stringt;
+with Uintp;
pragma Warnings (Off);
with System.HTable;
@@ -3676,6 +3677,7 @@ package body Make is
Linker_Switches.Init;
Csets.Initialize;
+ Uintp.Initialize;
Snames.Initialize;
Stringt.Initialize;
reply other threads:[~2022-06-02 9:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602090846.GA1010514@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=squirek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).