From: Segher Boessenkool <segher@kernel.crashing.org>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, David <dje.gcc@gmail.com>,
"Kewen.Lin" <linkw@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH v3, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605]
Date: Tue, 7 Jun 2022 15:44:26 -0500 [thread overview]
Message-ID: <20220607204426.GL25951@gate.crashing.org> (raw)
In-Reply-To: <10ddd127-6e61-3699-a3f2-f9141d127af5@linux.ibm.com>
Hi!
On Tue, Jun 07, 2022 at 09:51:43AM +0800, HAO CHEN GUI wrote:
> On 2/6/2022 上午 5:01, Segher Boessenkool wrote:
> > On Wed, May 18, 2022 at 04:52:26PM +0800, HAO CHEN GUI wrote:
> >> const double __builtin_vsx_xsmaxdp (double, double);
> >> - XSMAXDP smaxdf3 {}
> >> + XSMAXDP fmaxdf3 {}
> >>
> >> const double __builtin_vsx_xsmindp (double, double);
> >> - XSMINDP smindf3 {}
> >> + XSMINDP fmindf3 {}
> >
> > Are s{min,max}df3 still used after this?
>
> Expands reduc_s[min|max]_scal are still using s[min|max]df3.
Ah, and reduction is undefined for float unless fast-math anyway. Okay.
> Also we could implement reduc_f[min|max]_scal after committing
> this patch.
Because fmin and fmax treat NaNs as missing data. But you have to be
careful with SNaNs here, probably just skip most of this when
-fsignaling-nans is used. It also still needs -fno-signed-zeros btw,
but not full -ffast-math indeed.
Segher
prev parent reply other threads:[~2022-06-07 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 8:52 HAO CHEN GUI
2022-05-30 1:24 ` Ping " HAO CHEN GUI
2022-05-30 9:56 ` Kewen.Lin
2022-06-01 21:01 ` Segher Boessenkool
2022-06-07 1:51 ` HAO CHEN GUI
2022-06-07 20:44 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607204426.GL25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=linkw@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).