public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c: Handle initializations of opaque types [PR106016]
Date: Sat, 18 Jun 2022 09:58:18 -0500	[thread overview]
Message-ID: <20220618145818.GL25951@gate.crashing.org> (raw)
In-Reply-To: <009c391d-3994-8755-0d22-9e80faf91f42@linux.ibm.com>

Hi Peter,

On Fri, Jun 17, 2022 at 11:50:35PM -0500, Peter Bergner wrote:
> The initial commit that added opaque types thought that there couldn't
> be any valid initializations for variables of these types, but the test
> case in the bug report shows that isn't true.  The solution is to handle
> OPAQUE_TYPE initializations just like the other scalar types.
> 
> This passed bootstrap and regtesting with no regressions on powerpc64le-linux.
> Ok for trunk?  This is an issue in GCC 12 and 11 too.  Ok for the release
> branches after some burn-in on trunk?
> 
> Peter
> 
> gcc/
> 	PR c/106016
> 	* expr.cc (count_type_elements): Handle OPAQUE_TYPE.
> 
> gcc/testsuite/
> 	PR c/106016
> 	* gcc.target/powerpc/pr106016.c: New test.

The testcase is fine everywhere.  Thanks!


Segher

  reply	other threads:[~2022-06-18 14:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18  4:50 Peter Bergner
2022-06-18 14:58 ` Segher Boessenkool [this message]
2022-07-25 22:45 ` [PING][PATCH] c: Handle initializations of opaque types [PR106016] (need review of expr.cc hunk) Peter Bergner
2022-07-26  6:57   ` Richard Biener
2022-07-26 15:07     ` Peter Bergner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220618145818.GL25951@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).