From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
will schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH v3] rs6000: Adjust mov optabs for opaque modes [PR103353]
Date: Thu, 23 Jun 2022 14:06:19 -0500 [thread overview]
Message-ID: <20220623190619.GU25951@gate.crashing.org> (raw)
In-Reply-To: <09c34b29-feea-d26e-2c4f-5e096ab286bc@linux.ibm.com>
Hi!
On Wed, May 18, 2022 at 10:07:48PM +0800, Kewen.Lin wrote:
> As PR103353 shows, we may want to continue to expand a MMA built-in
> function like a normal function, even if we have already emitted
> error messages about some missing required conditions. As shown in
> that PR, without one explicit mov optab on OOmode provided, it would
> call emit_move_insn recursively.
First off: lxvp is a VSX insn, not an MMA insn. So please don't call it
that -- this confusion is what presumably caused the problem here, so it
would be good to root it out :-)
> + /* Opaque modes are only expected to be available when MMA is supported,
Why do people expect that? It is completely wrong. The name "opaque"
itself already says this is not just for MMA, but perhaps more
importantly, it is a basic VSX insn, doesn't touch any MMA resources,
and is useful in other contexts as well.
So this needs some bigger surgery.
Segher
next prev parent reply other threads:[~2022-06-23 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 14:07 Kewen.Lin
2022-06-06 8:53 ` PING^1 " Kewen.Lin
2022-06-23 2:02 ` PING^2 " Kewen.Lin
2022-06-23 19:06 ` Segher Boessenkool [this message]
2022-06-24 1:03 ` Kewen.Lin
2022-06-24 16:49 ` Segher Boessenkool
2022-06-27 2:47 ` Kewen.Lin
2022-07-28 8:49 ` PING^1 [PATCH v4] " Kewen.Lin
2022-08-15 8:07 ` PING^2 " Kewen.Lin
2022-08-15 21:30 ` [PATCH v3] " Segher Boessenkool
2022-08-16 5:53 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623190619.GU25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).