From: Fangrui Song <maskray@google.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep
Date: Fri, 24 Jun 2022 01:26:26 -0700 [thread overview]
Message-ID: <20220624082626.z7ma7ugyz5svlxf2@google.com> (raw)
In-Reply-To: <yddmte2fql0.fsf@CeBiTec.Uni-Bielefeld.DE>
On 2022-06-24, Rainer Orth wrote:
>Hi Xi,
>
>> On Fri, 2022-06-24 at 09:24 +0200, Rainer Orth wrote:
>>
>>> please remember that there's a world outside of GNU grep: e.g. Solaris
>>> /bin/grep doesn't support grep -E (while /usr/xpg4/bin/grep does), so
>>> unconditionally replacing egrep with grep -E in several places is
>>> likely
>>> to break at least the Solaris build.
>>>
>>> Please see the autoconf manual for details. I suspect you'll have to
>>> rework the patch set to use AC_PROG_EGREP and $EGREP instead.
>>
>> Thanks for the advice. I'll rework on it.
>>
>> Is there some way to access a Solaris and do some test?
>
>Sure: there's a Solaris 11.3/SPARC system (gcc211)in the GCC compile
>farm (https://gcc.gnu.org/wiki/CompileFarm).
>
>Unfortunately, there's neither Solaris 11.4 or Solaris/x86 at the
>moment, but those don't differ in this regard.
>
> Rainer
FWIW: glibc recently got the grep -E change and the solution is to use
plain grep -E, without $EGREP things.
Isn't setting PATH a good workaround if Solaris has the problem?
https://sourceware.org/pipermail/libc-alpha/2022-June/139420.html
> Yes, it is safe nowadays to use 'grep -E' instead of egrep. The only
> vendor-supported platform I know of where '/usr/bin/grep -E' does not
> work is Solaris 10 (end-of-life January 2024), and that's easily fixed
> by prepending /usr/xpg4/bin to PATH.
next prev parent reply other threads:[~2022-06-24 8:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 6:57 Xi Ruoyao
2022-06-24 6:58 ` [PATCH 1/8] config: use grep -E instead of egrep Xi Ruoyao
2022-06-24 7:00 ` [PATCH 2/8] fixincludes: use grep -E/-F instead of egrep/fgrep Xi Ruoyao
2022-06-24 7:02 ` [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts Xi Ruoyao
2022-06-24 10:00 ` Jonathan Wakely
2022-06-24 11:08 ` Xi Ruoyao
2022-06-24 11:18 ` Jonathan Wakely
2022-06-24 11:35 ` Jonathan Wakely
2022-06-24 11:41 ` Rainer Orth
2022-06-24 12:37 ` Xi Ruoyao
2022-06-24 12:38 ` Jonathan Wakely
2022-06-24 7:04 ` [PATCH 4/8] libbacktrace: use grep -F instead of fgrep Xi Ruoyao
2022-06-24 7:05 ` [PATCH 5/8] intl: stop using fgrep for exgettext Xi Ruoyao
2022-06-24 16:06 ` Joseph Myers
2022-06-25 4:00 ` Xi Ruoyao
2022-06-24 7:06 ` [PATCH 6/8] fortran: use grep -F instead of fgrep Xi Ruoyao
2022-06-24 11:13 ` Bernhard Reutner-Fischer
2022-06-24 12:22 ` Xi Ruoyao
2022-06-24 12:35 ` Rainer Orth
2022-06-24 18:30 ` Bernhard Reutner-Fischer
2022-06-24 13:58 ` Thomas Koenig
2022-06-24 7:09 ` [PATCH 7/8] testsuite: use grep -E instead of egrep Xi Ruoyao
2022-06-24 10:57 ` Arnaud Charlet
2022-06-24 7:10 ` [PATCH 8/8] contrib: " Xi Ruoyao
2022-06-24 7:24 ` [PATCH 0/8] Stop using obsoleted egrep/fgrep Rainer Orth
2022-06-24 7:27 ` Xi Ruoyao
2022-06-24 7:50 ` Rainer Orth
2022-06-24 8:26 ` Fangrui Song [this message]
2022-06-24 8:33 ` Andrew Pinski
2022-06-24 16:09 ` Joseph Myers
2022-06-24 16:21 ` Iain Sandoe
2022-06-24 8:45 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624082626.z7ma7ugyz5svlxf2@google.com \
--to=maskray@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).