From: soeren@soeren-tempel.net
To: gofrontend-dev@googlegroups.com
Cc: gcc-patches@gcc.gnu.org, iant@golang.org
Subject: [PATCH] mksysinfo: add support for musl libc
Date: Mon, 27 Jun 2022 18:44:16 +0200 [thread overview]
Message-ID: <20220627164415.8510-1-soeren@soeren-tempel.net> (raw)
From: Sören Tempel <soeren@soeren-tempel.net>
This patch addresses two minor compatibility issues with musl libc:
* On some architecture (e.g. PowerPC), musl has more than one field
prefixed with st_{a,m,c}tim in struct stat. This causes the sed(1)
invocation to not work correctly (since it will only replace the first
occurrence) [1]. This can be fixed by passing the 'g' flag to replace
all occurrences.
* Since version 1.2.3, musl defines SYS_SECCOMP in signal.h [2]. This
conflicts with mksysinfo extraction of syscall numbers [3]. By
restricting the grep expression to only match lower case characters we
can avoid a redefinition of SYS_SECCOMP. This is GCC PR 105225.
This patch combines two Alpine Linux patches which have been written by
Ariadne Conill and Natanael Copa. I haven't tested this with glibc but I
strongly suspect that both changes should not introduce any issue with
glibc.
[1]: https://git.musl-libc.org/cgit/musl/tree/arch/powerpc/bits/stat.h
[2]: https://git.musl-libc.org/cgit/musl/commit/?id=3dcbd896907d9d474da811b7c6b769342abaf651
[3]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105225
Signed-off-by: Sören Tempel <soeren@soeren-tempel.net>
---
libgo/mksysinfo.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libgo/mksysinfo.sh b/libgo/mksysinfo.sh
index 5aa30915..72044624 100755
--- a/libgo/mksysinfo.sh
+++ b/libgo/mksysinfo.sh
@@ -126,7 +126,7 @@ if ! grep '^const SIGCLD ' ${OUT} >/dev/null 2>&1; then
fi
# The syscall numbers. We force the names to upper case.
-grep '^const _SYS_' gen-sysinfo.go | \
+grep '^const _SYS_[a-z]' gen-sysinfo.go | \
sed -e 's/const _\(SYS_[^= ]*\).*$/\1/' | \
while read sys; do
sup=`echo $sys | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ`
@@ -506,7 +506,7 @@ fi
# For historical reasons Go uses the suffix "timespec" instead of "tim" for
# stat_t's time fields on NetBSD.
-st_times='-e s/st_atim/Atim/ -e s/st_mtim/Mtim/ -e s/st_ctim/Ctim/'
+st_times='-e s/st_atim/Atim/g -e s/st_mtim/Mtim/g -e s/st_ctim/Ctim/g'
if test "${GOOS}" = "netbsd"; then
st_times='-e s/st_atim/Atimespec/ -e s/st_mtim/Mtimespec/ -e s/st_ctim/Ctimespec/'
fi
next reply other threads:[~2022-06-27 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 16:44 soeren [this message]
2022-06-27 17:01 ` Ian Lance Taylor
2022-06-28 14:28 ` Sören Tempel
2022-06-29 22:24 ` Ian Lance Taylor
2022-06-30 16:59 ` Sören Tempel
2022-06-30 19:35 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627164415.8510-1-soeren@soeren-tempel.net \
--to=soeren@soeren-tempel.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).