From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Refine type for checking number of pragma arguments
Date: Wed, 13 Jul 2022 10:02:44 +0000 [thread overview]
Message-ID: <20220713100244.GA994494@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
Code cleanup.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* par-prag.adb (Check_Arg_Count): Change parameter type from Int
to Nat, because this parameter is compared to Arg_Count variable
which is of type Nat. Also, it wouldn't make sense to check for
negative number of pragma arguments.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 940 bytes --]
diff --git a/gcc/ada/par-prag.adb b/gcc/ada/par-prag.adb
--- a/gcc/ada/par-prag.adb
+++ b/gcc/ada/par-prag.adb
@@ -65,7 +65,7 @@ function Prag (Pragma_Node : Node_Id; Semi : Source_Ptr) return Node_Id is
-- the routine for the argument one past the last present argument, but
-- that is the only case in which a non-present argument can be referenced.
- procedure Check_Arg_Count (Required : Int);
+ procedure Check_Arg_Count (Required : Nat);
-- Check argument count for pragma = Required. If not give error and raise
-- Error_Resync.
@@ -155,7 +155,7 @@ function Prag (Pragma_Node : Node_Id; Semi : Source_Ptr) return Node_Id is
-- Check_Arg_Count --
---------------------
- procedure Check_Arg_Count (Required : Int) is
+ procedure Check_Arg_Count (Required : Nat) is
begin
if Arg_Count /= Required then
Error_Msg_N ("wrong number of arguments for pragma%", Pragma_Node);
reply other threads:[~2022-07-13 10:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713100244.GA994494@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).