From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, "Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [GCC 12 backport] Disable generating load/store vector pairs for block copies.
Date: Thu, 14 Jul 2022 16:12:14 -0500 [thread overview]
Message-ID: <20220714211214.GW25951@gate.crashing.org> (raw)
In-Reply-To: <YtA0WPOxxC4el7Ue@toto.the-meissners.org>
On Thu, Jul 14, 2022 at 11:20:56AM -0400, Michael Meissner wrote:
> I have applied the patch to GCC 12.
>
> | From 22736f3d0d4fb8ce4afb3230023f8accdb03a623 Mon Sep 17 00:00:00 2001
> | From: Michael Meissner <meissner@linux.ibm.com>
> | Date: Thu, 14 Jul 2022 11:16:08 -0400
> | Subject: [PATCH] [BACKPORT] Disable generating load/store vector pairs for block copies.
>
> Testing has found that using load and store vector pair for block copies
> can result in a slow down on power10. This patch disables using the
> vector pair instructions for block copies if we are tuning for power10.
>
> 2022-06-11 Michael Meissner <meissner@linux.ibm.com>
>
> gcc/
>
> * config/rs6000/rs6000.cc (rs6000_option_override_internal): Do
> not generate block copies with vector pair instructions if we are
> tuning for power10. Back port from master branch.
You never posted the trunk version of this, so that never was approved
either.
> +++ b/gcc/config/rs6000/rs6000.cc
> @@ -4151,7 +4151,10 @@ rs6000_option_override_internal (bool global_init_p)
>
> if (!(rs6000_isa_flags_explicit & OPTION_MASK_BLOCK_OPS_VECTOR_PAIR))
> {
> - if (TARGET_MMA && TARGET_EFFICIENT_UNALIGNED_VSX)
> + /* Do not generate lxvp and stxvp on power10 since there are some
> + performance issues. */
> + if (TARGET_MMA && TARGET_EFFICIENT_UNALIGNED_VSX
> + && rs6000_tune != PROCESSOR_POWER10)
> rs6000_isa_flags |= OPTION_MASK_BLOCK_OPS_VECTOR_PAIR;
> else
> rs6000_isa_flags &= ~OPTION_MASK_BLOCK_OPS_VECTOR_PAIR;
The TARGET_MMA in that should not be there. Please fix that (that
probably needs more changes).
This statement does the opposite of what the comment says.
Please fix this. On trunk, first.
Segher
next prev parent reply other threads:[~2022-07-14 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:27 [PATCH V2] " Michael Meissner
2022-06-10 17:30 ` Segher Boessenkool
2022-07-14 15:20 ` [GCC 12 backport] " Michael Meissner
2022-07-14 21:12 ` Segher Boessenkool [this message]
2022-07-14 21:49 ` Michael Meissner
2022-07-14 22:04 ` Segher Boessenkool
2022-07-14 18:07 ` [GCC 11 " Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714211214.GW25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=meissner@linux.ibm.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).