From: Claudiu Zissulescu <claziss@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: fbedard@synopsys.com, Claudiu Zissulescu <claziss@synopsys.com>
Subject: [committed 2/2] libgcc/arc: Update udivmodsi4 and make the lib safe for rf16
Date: Mon, 18 Jul 2022 15:00:36 +0300 [thread overview]
Message-ID: <20220718120036.3290240-2-claziss@gmail.com> (raw)
In-Reply-To: <20220718120036.3290240-1-claziss@gmail.com>
From: Claudiu Zissulescu <claziss@synopsys.com>
The ARC soft udivmodsi4 algorithm and as well as using umodsi3
for reduced register set configurations are wrong.
libgcc/
* config/arc/lib2funcs.c (udivmodsi4): Update AND mask.
* config/arc/lib1funcs.S (umodsi3): Don't use it for RF16
configurations.
---
libgcc/config/arc/lib1funcs.S | 2 ++
libgcc/config/arc/lib2funcs.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libgcc/config/arc/lib1funcs.S b/libgcc/config/arc/lib1funcs.S
index 14fd1d2f303..b06361257d1 100644
--- a/libgcc/config/arc/lib1funcs.S
+++ b/libgcc/config/arc/lib1funcs.S
@@ -936,6 +936,7 @@ SYM(__divsi3):
#endif /* L_divsi3 */
+#ifndef __ARC_RF16__
#ifdef L_umodsi3
.section .text
.align 4
@@ -950,6 +951,7 @@ SYM(__umodsi3):
ENDFUNC(__umodsi3)
#endif /* L_umodsi3 */
+#endif /* !__ARC_RF16__ */
#ifdef L_modsi3
.section .text
diff --git a/libgcc/config/arc/lib2funcs.c b/libgcc/config/arc/lib2funcs.c
index 70727b55365..8cba45172b2 100644
--- a/libgcc/config/arc/lib2funcs.c
+++ b/libgcc/config/arc/lib2funcs.c
@@ -59,7 +59,7 @@ udivmodsi4 (nint32_t num, nint32_t den, word_t modwanted)
nint32_t bit = 1;
nint32_t res = 0;
- while (den < num && bit && !(den & (1LL << 63)))
+ while (den < num && bit && !(den & (1L << 31)))
{
den <<= 1;
bit <<= 1;
--
2.30.2
prev parent reply other threads:[~2022-07-18 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 12:00 [committed 1/2] arc: Fix interrupt's epilogue Claudiu Zissulescu
2022-07-18 12:00 ` Claudiu Zissulescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718120036.3290240-2-claziss@gmail.com \
--to=claziss@gmail.com \
--cc=claziss@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).