From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 91B17383A379 for ; Thu, 21 Jul 2022 18:49:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91B17383A379 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 26LIm6FC001208; Thu, 21 Jul 2022 13:48:07 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 26LIm6sU001207; Thu, 21 Jul 2022 13:48:06 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 21 Jul 2022 13:48:06 -0500 From: Segher Boessenkool To: "Kewen.Lin" Cc: GCC Patches , David Edelsohn , Peter Bergner Subject: Re: [PATCH] rs6000/test: Update some cases with -mdejagnu-tune Message-ID: <20220721184806.GK25951@gate.crashing.org> References: <4847b51d-dde2-916b-27aa-8e63518d66d2@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4847b51d-dde2-916b-27aa-8e63518d66d2@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 18:49:08 -0000 Hi! On Wed, Jul 20, 2022 at 05:31:11PM +0800, Kewen.Lin wrote: > As PR106345 shows, some test cases should be updated with > -mdejagnu-tune, since their test points are sensitive to > rs6000_tune, such as: group_ending_nop, loop align (ic), > float conversion cost etc. It does not make sense to require -mdejagnu-tune= if -mdejagnu-cpu= is already given? What is the failure case? > This patch is to replace -mdejagnu-cpu with -mdejagnu-tune > or append -mdejagnu-tune (keep the original -mdejagnu-cpu > when it's required) accordingly. It is *always* required. Testcases with -mtune= but unspecified -mcpu= make no sense. > --- a/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c > +++ b/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c > @@ -1,5 +1,5 @@ > /* { dg-do compile { target powerpc_fprs } } */ > -/* { dg-options "-O2 -fpic -mdejagnu-cpu=power5" } */ > +/* { dg-options "-O2 -fpic -mdejagnu-cpu=power5 -mdejagnu-tune=power5" } */ > /* { dg-require-effective-target fpic } */ This should only make a difference if you have -mtune= in your RUNTEST_FLAGS, and you shouldn't do silly things like that. I suspect you see it in other cases, and those are actual bugs then, that need actual fixing instead of sweeping under the carper. The testcase suggests this is with a compiler configured with --with-cpu= --with-tune=, which should just work, and -mcpu= should override both of those! Segher