From: Segher Boessenkool <segher@kernel.crashing.org>
To: Roger Sayle <roger@nextmovesoftware.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add new target hook: simplify_modecc_const.
Date: Wed, 27 Jul 2022 13:37:06 -0500 [thread overview]
Message-ID: <20220727183706.GD25951@gate.crashing.org> (raw)
In-Reply-To: <003501d8a18d$c22ed760$468c8620$@nextmovesoftware.com>
On Wed, Jul 27, 2022 at 08:51:58AM +0100, Roger Sayle wrote:
> > They can be, as clearly documented (and obvious from the code), but you
> can
> > not ever have that in the RTL stream, which is needed for your patch to do
> > anything.
>
> That's the misunderstanding; neither this nor the previous SUBREG patch,
> affect/change what is in the RTL stream, no COMPARE nodes are every
> changed or modified, only eliminated by the propagation/fusion in combine
> (or CSE).
There are no guarantees at all for that though?
> We have --enable-checking=rtl to guarantee that the documented invariants
> always hold in the RTL stream.
That unfortunately only checks a few structural constraints, and not
even all. For example not that STRICT_LOW_PART has a SUBREG as
argument, which is documented, and the only thing that makes sense
anyway. This is PR106101. Unfortunately many targets violate this.
Segher
next prev parent reply other threads:[~2022-07-27 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 21:08 [PATCH] Be careful with MODE_CC in simplify_const_relational_operation Roger Sayle
2022-07-07 22:38 ` Segher Boessenkool
2022-07-26 12:13 ` [PATCH] Add new target hook: simplify_modecc_const Roger Sayle
2022-07-26 17:44 ` Segher Boessenkool
2022-07-26 21:04 ` Roger Sayle
2022-07-26 22:11 ` Segher Boessenkool
2022-07-27 7:51 ` Roger Sayle
2022-07-27 18:37 ` Segher Boessenkool [this message]
2022-07-28 12:39 ` Richard Sandiford
2022-10-10 15:50 ` H.J. Lu
2022-10-14 20:31 ` Jeff Law
2022-10-14 21:05 ` H.J. Lu
2022-10-14 20:26 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727183706.GD25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=roger@nextmovesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).