From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id C9A933858C83 for ; Mon, 1 Aug 2022 07:25:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9A933858C83 Received: by mail-wr1-x436.google.com with SMTP id p10so8775011wru.8 for ; Mon, 01 Aug 2022 00:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K1V9HcNkeUMRvcAw+qMaBZv2zCObAdywBvVwGBTPHyo=; b=lfIGUr5Q0SWo2PU+vp05HFSdLyepjfbVoPk07oUm+81ibR8y9U/9zwXxXqukNr+lPL O8uYHWCVh0HMkDpyCBvin20VVt3lVuRLOFADpw3cXwEef1fZUSYKjxchnEXBi0x7rteU YUCZxn9eOEjCiF9qtqntWghD6tF/Sxp112zk/JtGWj4ILpJWESvlfNLcNDAOgx70hjVw qjoT0bMJ+VkpAhmTID9B5EtUfylKSyUBrfUoYH4RuFPrQvUal1UI+w48JFXwJphhM9DL X6XhXMGgvdDdRRXgrRjwVF5wjMi8HJQGgaNvJrweK7ZzoMAtetHdgAFqTisYxjOhZo74 F2RQ== X-Gm-Message-State: ACgBeo0uinmV/ghya7AYKT7BDIFQpcQPiRWjpBlOKsYnRHxJla539+4u Hdz4eIy6+2H1uX0hoNZMu+2MYg== X-Google-Smtp-Source: AA6agR7f3hU16wG9Q4sRhbV+aW42bGagcfwJs/4kUruVYmS4J2LkzuniqeAUneAq+FcuGDnvl4W5pQ== X-Received: by 2002:adf:ee4b:0:b0:21e:4ecf:b150 with SMTP id w11-20020adfee4b000000b0021e4ecfb150mr9432488wro.290.1659338727027; Mon, 01 Aug 2022 00:25:27 -0700 (PDT) Received: from localhost ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id o12-20020a05600c4fcc00b003a31d200a7dsm14831938wmq.9.2022.08.01.00.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 00:25:26 -0700 (PDT) Date: Mon, 1 Aug 2022 07:25:25 +0000 From: Arnaud Charlet To: Roger Sayle Cc: 'GCC Patches' , 'Eric Botcazou' Subject: Re: [Ada PATCH] Update configure to check for a recent gnat Ada compiler. Message-ID: <20220801072525.GA12284@adacore.com> References: <004601d8a460$940e7220$bc2b5660$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <004601d8a460$940e7220$bc2b5660$@nextmovesoftware.com> X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 07:25:30 -0000 > GCC fails to bootstrap when configured with --enable-languages=all on > machines that have older versions of GNAT installed as the system Ada > compiler. In configure, it's not sufficient to check whether gnat is > available, but whether a sufficiently recent version of GNAT is > installed. This patch tweaks config/acx.m4 so that conftest.adb also > contains a reference to System.CRTL.int64 as required by the current > version of gcc/ada/osint.adb. This fixes the build when the system > Ada is GNAT v4.8.5 (on Redhat 7) by disabling ada, but continues to > work fine when the system Ada is GNAT v11.3.1. > > Tested in x86_64-pc-linux-gnu. Ok for mainline? > > > 2022-07-30 Roger Sayle > > ChangeLog > * config/acx.me (AC_PROG_GNAT): Update conftest.adb to include > features required of the host gnat compiler. > * configure: Regenerate. > > Thanks in advance, > Roger > -- > > diff --git a/config/acx.m4 b/config/acx.m4 > index b86c4f9..bd3e7f8 100644 > --- a/config/acx.m4 > +++ b/config/acx.m4 > @@ -396,6 +396,10 @@ AC_CHECK_TOOL(GNATMAKE, gnatmake, no) > AC_CACHE_CHECK([whether compiler driver understands Ada], I'd suggest changing the text above to e.g. "whether compiler driver understands Ada and is recent enough" OK with this change, thanks! > acx_cv_cc_gcc_supports_ada, > [cat >conftest.adb < +pragma Warnings (Off); > +with System.CRTL; > +pragma Warnings (On); > +use type System.CRTL.int64; > procedure conftest is begin null; end conftest; > EOF > acx_cv_cc_gcc_supports_ada=no > diff --git a/configure b/configure > index 65d7078..3ddcc9f 100755 > --- a/configure > +++ b/configure > @@ -5608,6 +5608,10 @@ if ${acx_cv_cc_gcc_supports_ada+:} false; then : > $as_echo_n "(cached) " >&6 > else > cat >conftest.adb < +pragma Warnings (Off); > +with System.CRTL; > +pragma Warnings (On); > +use type System.CRTL.int64; > procedure conftest is begin null; end conftest; > EOF > acx_cv_cc_gcc_supports_ada=no