From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 7D2F4385840B for ; Wed, 10 Aug 2022 13:47:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D2F4385840B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 664EA38272 for ; Wed, 10 Aug 2022 13:47:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 51ABC13AB3 for ; Wed, 10 Aug 2022 13:47:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /JmdEt+282KOIQAAMHmgww (envelope-from ) for ; Wed, 10 Aug 2022 13:47:11 +0000 Date: Wed, 10 Aug 2022 15:47:10 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/106513 - fix mistake in bswap symbolic number shifts MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20220810134711.51ABC13AB3@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 13:47:13 -0000 This fixes a mistake in typing a local variable in the symbolic shift routine. Bootstrap & regtest pending on x86_64-unknown-linux-gnu. PR tree-optimization/106513 * gimple-ssa-store-merging.cc (do_shift_rotate): Use uint64_t for head_marker. * gcc.dg/torture/pr106513.c: New testcase. --- gcc/gimple-ssa-store-merging.cc | 2 +- gcc/testsuite/gcc.dg/torture/pr106513.c | 26 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr106513.c diff --git a/gcc/gimple-ssa-store-merging.cc b/gcc/gimple-ssa-store-merging.cc index 0640168bcc4..b80b8eac444 100644 --- a/gcc/gimple-ssa-store-merging.cc +++ b/gcc/gimple-ssa-store-merging.cc @@ -263,7 +263,7 @@ do_shift_rotate (enum tree_code code, int count) { int i, size = TYPE_PRECISION (n->type) / BITS_PER_UNIT; - unsigned head_marker; + uint64_t head_marker; if (count < 0 || count >= TYPE_PRECISION (n->type) diff --git a/gcc/testsuite/gcc.dg/torture/pr106513.c b/gcc/testsuite/gcc.dg/torture/pr106513.c new file mode 100644 index 00000000000..92c02ffb37b --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr106513.c @@ -0,0 +1,26 @@ +/* { dg-do run } */ + +typedef __INT64_TYPE__ int64_t; + +__attribute__((noinline)) int64_t +swap64 (int64_t n) +{ + return (((n & (((int64_t) 0xff) )) << 56) | + ((n & (((int64_t) 0xff) << 8)) << 40) | + ((n & (((int64_t) 0xff) << 16)) << 24) | + ((n & (((int64_t) 0xff) << 24)) << 8) | + ((n & (((int64_t) 0xff) << 32)) >> 8) | + ((n & (((int64_t) 0xff) << 40)) >> 24) | + ((n & (((int64_t) 0xff) << 48)) >> 40) | + ((n & ((int64_t)(0xffull << 56))) >> 56)); +} + +int main (void) +{ + volatile int64_t n = 0x8000000000000000l; + + if (swap64(n) != 0xffffffffffffff80l) + __builtin_abort (); + + return 0; +} -- 2.35.3