From: Jiufu Guo <guojiufu@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org,
guojiufu@linux.ibm.com
Subject: [PATCH] rs6000: avoid ineffective replacement of splitters
Date: Fri, 12 Aug 2022 14:39:59 +0800 [thread overview]
Message-ID: <20220812063959.151705-1-guojiufu@linux.ibm.com> (raw)
Hi,
As a comment in
https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599556.html
Those splitters call rs6000_emit_set_const directly, and the replacements
are never used. Using (pc) would be less misleading.
This patch pass bootstrap®test on ppc64 BE and LE.
Is this ok for trunk.
BR,
Jeff(Jiufu)
gcc/ChangeLog:
* config/rs6000/rs6000.md: (constant splitters): Use "(pc)" as the
replacements.
---
gcc/config/rs6000/rs6000.md | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 1367a2cb779..7fadbeef1aa 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -7727,11 +7727,7 @@ (define_split
[(set (match_operand:SI 0 "gpc_reg_operand")
(match_operand:SI 1 "const_int_operand"))]
"num_insns_constant (operands[1], SImode) > 1"
- [(set (match_dup 0)
- (match_dup 2))
- (set (match_dup 0)
- (ior:SI (match_dup 0)
- (match_dup 3)))]
+ [(pc)]
{
if (rs6000_emit_set_const (operands[0], operands[1]))
DONE;
@@ -9662,8 +9658,7 @@ (define_split
[(set (match_operand:DI 0 "int_reg_operand_not_pseudo")
(match_operand:DI 1 "const_int_operand"))]
"TARGET_POWERPC64 && num_insns_constant (operands[1], DImode) > 1"
- [(set (match_dup 0) (match_dup 2))
- (set (match_dup 0) (plus:DI (match_dup 0) (match_dup 3)))]
+ [(pc)]
{
if (rs6000_emit_set_const (operands[0], operands[1]))
DONE;
@@ -9675,8 +9670,7 @@ (define_split
[(set (match_operand:DI 0 "int_reg_operand_not_pseudo")
(match_operand:DI 1 "const_scalar_int_operand"))]
"TARGET_POWERPC64 && num_insns_constant (operands[1], DImode) > 1"
- [(set (match_dup 0) (match_dup 2))
- (set (match_dup 0) (plus:DI (match_dup 0) (match_dup 3)))]
+ [(pc)]
{
if (rs6000_emit_set_const (operands[0], operands[1]))
DONE;
--
2.17.1
next reply other threads:[~2022-08-12 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 6:39 Jiufu Guo [this message]
2022-08-12 9:41 ` Kewen.Lin
2022-08-17 2:40 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812063959.151705-1-guojiufu@linux.ibm.com \
--to=guojiufu@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).