From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 469F338582B9 for ; Mon, 22 Aug 2022 13:37:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 469F338582B9 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0D8371F9C1 for ; Mon, 22 Aug 2022 13:37:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EF80E13523 for ; Mon, 22 Aug 2022 13:37:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ISdqOY+GA2MwZwAAMHmgww (envelope-from ) for ; Mon, 22 Aug 2022 13:37:19 +0000 Date: Mon, 22 Aug 2022 15:37:19 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Remove dead predicate analysis GENERIC expr building code MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Message-Id: <20220822133719.EF80E13523@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 13:37:22 -0000 The following removes the unused def_expr, use_expr and expr APIs from the predicate class including the unconditional build of the GENERIC use_expr on each uninit analysis run. Bootstrap & regtest running on x86_64-unknown-linux-gnu. * gimple-predicate-analysis.h (predicate::m_use_expr): Remove. (predicate::def_expr): Likewise. (predicate::use_expr): Likewise. (predicate::expr): Likewise. * gimple-predicate-analysis.cc (predicate::def_expr): Remove. (predicate::use_expr): Likewise. (predicate::expr): Likewise. (predicate::is_use_guarded): Do not build m_use_expr. --- gcc/gimple-predicate-analysis.cc | 39 -------------------------------- gcc/gimple-predicate-analysis.h | 16 ++----------- 2 files changed, 2 insertions(+), 53 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index 820a9bde28a..d1b0d1283dc 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -1892,7 +1892,6 @@ predicate::is_use_guarded (gimple *use_stmt, basic_block use_bb, /* Lazily initialize *THIS from the PHI and build its use expression. */ init_from_phi_def (phi); - m_use_expr = build_pred_expr (use_preds.m_preds); } /* The use is not guarded. */ @@ -1921,7 +1920,6 @@ predicate::is_use_guarded (gimple *use_stmt, basic_block use_bb, /* Lazily initialize *THIS from PHI. */ if (!init_from_phi_def (phi)) { - m_use_expr = build_pred_expr (use_preds.m_preds); return false; } @@ -1938,8 +1936,6 @@ predicate::is_use_guarded (gimple *use_stmt, basic_block use_bb, if (superset_of (use_preds)) return true; - m_use_expr = build_pred_expr (use_preds.m_preds); - return false; } @@ -2326,38 +2322,3 @@ predicate::init_from_control_deps (const vec *dep_chains, /* Clear M_PREDS to indicate failure. */ m_preds.release (); } - -/* Return the predicate expression guarding the definition of - the interesting variable. When INVERT is set, return the logical - NOT of the predicate. */ - -tree -predicate::def_expr (bool invert /* = false */) const -{ - /* The predicate is stored in an inverted form. */ - return build_pred_expr (m_preds, !invert); -} - -/* Return the predicate expression guarding the use of the interesting - variable or null if the use predicate hasn't been determined yet. */ - -tree -predicate::use_expr () const -{ - return m_use_expr; -} - -/* Return a logical AND expression with the (optionally inverted) predicate - expression guarding the definition of the interesting variable and one - guarding its use. Return null if the use predicate hasn't yet been - determined. */ - -tree -predicate::expr (bool invert /* = false */) const -{ - if (!m_use_expr) - return NULL_TREE; - - tree expr = build_pred_expr (m_preds, !invert); - return build2 (TRUTH_AND_EXPR, boolean_type_node, expr, m_use_expr); -} diff --git a/gcc/gimple-predicate-analysis.h b/gcc/gimple-predicate-analysis.h index c1843e89bbb..204cdbccfc7 100644 --- a/gcc/gimple-predicate-analysis.h +++ b/gcc/gimple-predicate-analysis.h @@ -69,11 +69,11 @@ class predicate /* Construct with the specified EVAL object. */ predicate (func_t &eval) - : m_preds (vNULL), m_eval (eval), m_use_expr () { } + : m_preds (vNULL), m_eval (eval) { } /* Copy. */ predicate (const predicate &rhs) - : m_preds (vNULL), m_eval (rhs.m_eval), m_use_expr () + : m_preds (vNULL), m_eval (rhs.m_eval) { *this = rhs; } @@ -109,15 +109,6 @@ class predicate bool is_use_guarded (gimple *, basic_block, gphi *, unsigned, hash_set *); - /* Return the predicate expression guarding the definition of - the interesting variable, optionally inverted. */ - tree def_expr (bool = false) const; - /* Return the predicate expression guarding the use of the interesting - variable. */ - tree use_expr () const; - - tree expr (bool = false) const; - private: bool includes (const pred_chain &) const; bool superset_of (const predicate &) const; @@ -145,9 +136,6 @@ private: pred_chain_union m_preds; /* Callback to evaluate an operand. Return true if it's interesting. */ func_t &m_eval; - /* The predicate expression guarding the use of the interesting - variable. */ - tree m_use_expr; }; /* Bit mask handling macros. */ -- 2.35.3