public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marek Polacek <polacek@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	Richard Biener <rguenther@suse.de>
Subject: [PATCH] testsuite: Add test for r11-4123
Date: Mon, 22 Aug 2022 12:57:37 -0400	[thread overview]
Message-ID: <20220822165737.39118-1-polacek@redhat.com> (raw)

r11-4123 came without a test but I happened upon a nice test case that
got fixed by that revision.  So I think it'd be good to add it.  The
ICE was:

phi-1.C: In constructor 'ElementManager::ElementManager()':
phi-1.C:28:1: error: missing definition
   28 | ElementManager::ElementManager() : array_(makeArray()) {}
      | ^~~~~~~~~~~~~~
for SSA_NAME: _12 in statement:
_10 = PHI <_12(3), _11(5)>
PHI argument
_12
for PHI node
_10 = PHI <_12(3), _11(5)>
during GIMPLE pass: fixup_cfg
phi-1.C:28:1: internal compiler error: verify_ssa failed

Incidentally, do you think it's safe to backport r11-4123 to GCC 8
(downstream)?  Thanks.

Tested on x86_64-pc-linux-gnu, ok for trunk?

gcc/testsuite/ChangeLog:

	* g++.dg/tree-ssa/phi-1.C: New test.
---
 gcc/testsuite/g++.dg/tree-ssa/phi-1.C | 28 +++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 gcc/testsuite/g++.dg/tree-ssa/phi-1.C

diff --git a/gcc/testsuite/g++.dg/tree-ssa/phi-1.C b/gcc/testsuite/g++.dg/tree-ssa/phi-1.C
new file mode 100644
index 00000000000..26cade052e3
--- /dev/null
+++ b/gcc/testsuite/g++.dg/tree-ssa/phi-1.C
@@ -0,0 +1,28 @@
+// { dg-do compile { target c++11 } }
+// { dg-options "-O --param early-inlining-insns=14" }
+
+struct Element;
+template <int _Nm> struct __array_traits { typedef Element _Type[_Nm]; };
+template <int _Nm> struct array {
+  typename __array_traits<_Nm>::_Type _M_elems;
+};
+bool logLevel();
+struct LogCapture {
+  void stream();
+};
+struct Element {
+  Element();
+  long data_;
+};
+using ElementArray = array<6>;
+struct ElementManager {
+  ElementManager();
+  ElementArray array_;
+};
+static ElementArray makeArray() {
+  if (logLevel())
+    LogCapture().stream();
+  ElementArray foo;
+  return foo;
+}
+ElementManager::ElementManager() : array_(makeArray()) {}

base-commit: b6316324fceaef431799a8b386de5cc9881d6898
-- 
2.37.2


             reply	other threads:[~2022-08-22 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 16:57 Marek Polacek [this message]
2022-08-22 17:16 ` Andrew Pinski
2022-08-22 17:45   ` [PATCH v2] " Marek Polacek
2022-08-23  6:27     ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822165737.39118-1-polacek@redhat.com \
    --to=polacek@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).