public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Add newline when checking path profitability.
Date: Tue, 23 Aug 2022 12:12:03 +0200	[thread overview]
Message-ID: <20220823101203.874506-1-aldyh@redhat.com> (raw)

It looks like we're missing a newline for cases where we don't print
anything.

OK?

gcc/ChangeLog:

	* tree-ssa-threadbackward.cc (possibly_profitable_path_p): Always
	add newline.
	(profitable_path_p): Same.
---
 gcc/tree-ssa-threadbackward.cc | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gcc/tree-ssa-threadbackward.cc b/gcc/tree-ssa-threadbackward.cc
index 3218ad931ef..9725f50e639 100644
--- a/gcc/tree-ssa-threadbackward.cc
+++ b/gcc/tree-ssa-threadbackward.cc
@@ -719,7 +719,11 @@ back_threader_profitability::possibly_profitable_path_p
 	      gimple *stmt = gsi_stmt (gsi);
 	      if (gimple_call_internal_p (stmt, IFN_UNIQUE)
 		  || gimple_call_builtin_p (stmt, BUILT_IN_CONSTANT_P))
-		return false;
+		{
+		  if (dump_file && (dump_flags & TDF_DETAILS))
+		    fputc ('\n', dump_file);
+		  return false;
+		}
 	      /* Do not count empty statements and labels.  */
 	      if (gimple_code (stmt) != GIMPLE_NOP
 		  && !is_gimple_debug (stmt))
@@ -821,6 +825,8 @@ back_threader_profitability::possibly_profitable_path_p
 		    && (m_n_insns * param_fsm_scale_path_stmts
 			>= param_max_jump_thread_duplication_stmts));
 
+  if (dump_file && (dump_flags & TDF_DETAILS))
+    fputc ('\n', dump_file);
   return true;
 }
 
@@ -947,6 +953,8 @@ back_threader_profitability::profitable_path_p (const vec<basic_block> &m_path,
 		 "non-empty latch\n");
       return false;
     }
+  if (dump_file && (dump_flags & TDF_DETAILS))
+    fputc ('\n', dump_file);
   return true;
 }
 
-- 
2.37.1


             reply	other threads:[~2022-08-23 10:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 10:12 Aldy Hernandez [this message]
2022-08-23 12:38 ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823101203.874506-1-aldyh@redhat.com \
    --to=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).