From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: Surya Kumari Jangala <jskumari@linux.vnet.ibm.com>,
gcc-patches@gcc.gnu.org, pthaugen@us.ibm.com
Subject: Re: [PATCH] sched1: Fix -fcompare-debug issue in schedule_region [PR105586]
Date: Tue, 23 Aug 2022 08:28:47 -0500 [thread overview]
Message-ID: <20220823132846.GT25951@gate.crashing.org> (raw)
In-Reply-To: <92671542-b6b9-e39a-b483-514dffc4773a@linux.ibm.com>
Hi!
On Tue, Aug 23, 2022 at 07:55:22AM -0500, Peter Bergner wrote:
> It looks good to me, but I cannot approve it.
Same here (both statements).
> That said, you're missing
> a ChangeLog entry for your new helper function. The ChangeLog mentions
> what changed, not why it changed.
And that is correct! Changelogs should not say that, that isn't their
purpose (in GCC), not what they are used for. Explanations like that go
in the email and/or the commit message.
The main remaining usefulness of changelogs is to spot unintended
commmits.
> Maybe something like the following?
>
> gcc/
> PR rtl-optimization/105586
> * sched-rgn.cc (save_state_for_fallthru_edge): New function.
> (schedule_region): Use it for all blocks.
That looks perfect, it doesn't say "why" either :-)
Segher
next prev parent reply other threads:[~2022-08-23 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 11:49 Surya Kumari Jangala
2022-08-23 12:55 ` Peter Bergner
2022-08-23 13:28 ` Segher Boessenkool [this message]
2022-08-24 8:10 ` Surya Kumari Jangala
2022-08-30 12:27 ` Richard Sandiford
2022-08-31 15:39 ` Jeff Law
2022-09-20 7:17 ` Surya Kumari Jangala
2022-09-21 7:33 ` Richard Biener
2022-11-08 16:36 ` Surya Kumari Jangala
2022-11-08 17:32 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823132846.GT25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jskumari@linux.vnet.ibm.com \
--cc=pthaugen@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).