From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 2/2] Refactor init_use_preds and find_control_equiv_block
Date: Fri, 26 Aug 2022 14:34:13 +0200 (CEST) [thread overview]
Message-ID: <20220826123414.39C2D13A7E@imap2.suse-dmz.suse.de> (raw)
The following inlines find_control_equiv_block and is_loop_exit
into init_use_preds and refactors that for better readability and
similarity with the post-dominator walk in compute_control_dep_chain.
* gimple-predicate-analysis.cc (is_loop_exit,
find_control_equiv_block): Inline into single caller ...
(uninit_analysis::init_use_preds): ... here and refactor.
---
gcc/gimple-predicate-analysis.cc | 55 ++++++++++----------------------
1 file changed, 16 insertions(+), 39 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc
index 934e9516e7b..e388bb37685 100644
--- a/gcc/gimple-predicate-analysis.cc
+++ b/gcc/gimple-predicate-analysis.cc
@@ -59,33 +59,6 @@
for the case corresponding to an edge. */
#define MAX_SWITCH_CASES 40
-/* Return true if, when BB1 is postdominating BB2, BB1 is a loop exit. */
-
-static bool
-is_loop_exit (basic_block bb2, basic_block bb1)
-{
- return single_pred_p (bb1) && !single_succ_p (bb2);
-}
-
-/* Find BB's closest postdominator that is its control equivalent (i.e.,
- that's controlled by the same predicate). */
-
-static inline basic_block
-find_control_equiv_block (basic_block bb)
-{
- basic_block pdom = get_immediate_dominator (CDI_POST_DOMINATORS, bb);
-
- /* Skip the postdominating bb that is also a loop exit. */
- if (is_loop_exit (bb, pdom))
- return NULL;
-
- /* If the postdominator is dominated by BB, return it. */
- if (dominated_by_p (CDI_DOMINATORS, pdom, bb))
- return pdom;
-
- return NULL;
-}
-
/* Return true if X1 is the negation of X2. */
static inline bool
@@ -1991,25 +1964,29 @@ bool
uninit_analysis::init_use_preds (predicate &use_preds, basic_block def_bb,
basic_block use_bb)
{
- gcc_assert (use_preds.is_empty ());
+ gcc_assert (use_preds.is_empty ()
+ && dominated_by_p (CDI_DOMINATORS, use_bb, def_bb));
/* Set CD_ROOT to the basic block closest to USE_BB that is the control
equivalent of (is guarded by the same predicate as) DEF_BB that also
- dominates USE_BB. */
+ dominates USE_BB. This mimics the inner loop in
+ compute_control_dep_chain. */
basic_block cd_root = def_bb;
- while (dominated_by_p (CDI_DOMINATORS, use_bb, cd_root))
+ do
{
- /* Find CD_ROOT's closest postdominator that's its control
- equivalent. */
- if (basic_block bb = find_control_equiv_block (cd_root))
- if (dominated_by_p (CDI_DOMINATORS, use_bb, bb))
- {
- cd_root = bb;
- continue;
- }
+ basic_block pdom = get_immediate_dominator (CDI_POST_DOMINATORS, cd_root);
- break;
+ /* Stop at a loop exit which is also postdominating cd_root. */
+ if (single_pred_p (pdom) && !single_succ_p (cd_root))
+ break;
+
+ if (!dominated_by_p (CDI_DOMINATORS, pdom, cd_root)
+ || !dominated_by_p (CDI_DOMINATORS, use_bb, pdom))
+ break;
+
+ cd_root = pdom;
}
+ while (1);
/* Set DEP_CHAINS to the set of edges between CD_ROOT and USE_BB.
Each DEP_CHAINS element is a series of edges whose conditions
--
2.35.3
reply other threads:[~2022-08-26 12:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826123414.39C2D13A7E@imap2.suse-dmz.suse.de \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).