From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] tree-optimization/67196 - normalize use predicates earlier
Date: Tue, 30 Aug 2022 11:13:44 +0000 (UTC) [thread overview]
Message-ID: <20220830111344.OQ9J61s-yWrObxGkrYdsDBkSyvMuge7kI6xgTWlQqwQ@z> (raw)
The following makes sure to have use predicates simplified and
normalized before doing uninit_analysis::overlap because that
otherwise cannot pick up all flag setting cases. This fixes
half of the issue in PR67196 and conveniently resolves the
XFAIL in gcc.dg/uninit-pred-7_a.c.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR tree-optimization/67196
* gimple-predicate-analysis.cc (uninit_analysis::is_use_guarded):
Simplify and normalize use prediates before first use.
* gcc.dg/uninit-pred-7_a.c: Un-XFAIL.
---
gcc/gimple-predicate-analysis.cc | 6 +++---
gcc/testsuite/gcc.dg/uninit-pred-7_a.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc
index ffdd8a15fe7..62a13c39d7a 100644
--- a/gcc/gimple-predicate-analysis.cc
+++ b/gcc/gimple-predicate-analysis.cc
@@ -2087,6 +2087,9 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb,
if (!init_use_preds (use_preds, def_bb, use_bb))
return false;
+ use_preds.simplify (use_stmt, /*is_use=*/true);
+ use_preds.normalize (use_stmt, /*is_use=*/true);
+
/* Try to prune the dead incoming phi edges. */
if (!overlap (phi, opnds, visited, use_preds))
{
@@ -2106,9 +2109,6 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb,
m_phi_def_preds.normalize (phi);
}
- use_preds.simplify (use_stmt, /*is_use=*/true);
- use_preds.normalize (use_stmt, /*is_use=*/true);
-
/* Return true if the predicate guarding the valid definition (i.e.,
*THIS) is a superset of the predicate guarding the use (i.e.,
USE_PREDS). */
diff --git a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c
index 434d90ac570..c2ba2a4248d 100644
--- a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c
+++ b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c
@@ -23,7 +23,7 @@ int foo (int n, int l, int m, int r)
blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */
if ( l )
- blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail *-*-* } } */
+ blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */
return 0;
}
--
2.35.3
next reply other threads:[~2022-08-30 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 11:13 Richard Biener [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-30 11:13 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830111344.OQ9J61s-yWrObxGkrYdsDBkSyvMuge7kI6xgTWlQqwQ@z \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).