From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rs6000: Don't ICE when we disassemble an MMA variable [PR101322]
Date: Wed, 31 Aug 2022 10:58:25 -0500 [thread overview]
Message-ID: <20220831155825.GQ25951@gate.crashing.org> (raw)
In-Reply-To: <c7d29335-ac3a-24d4-486e-7755018263bf@linux.ibm.com>
Hi!
On Fri, Aug 26, 2022 at 10:50:00PM -0500, Peter Bergner wrote:
> When we expand an MMA disassemble built-in with C++ using a pointer that
> is casted to a valid MMA type, the type isn't passed down to the expand
(The perfect tense of cast is "cast").
> machinery and we end up using the base type of the pointer which leads to
> an ICE. This patch enforces we always use the correct MMA type regardless
> of the pointer type being used.
> --- /dev/null
> +++ b/gcc/testsuite/g++.target/powerpc/pr101322.C
> @@ -0,0 +1,17 @@
> +/* PR target/101322 */
> +/* { dg-options "-O2 -mdejagnu-cpu=power10" } */
> +/* { dg-require-effective-target power10_ok } */
These should be the other way around. It makes no sense to set option X
before testing if you can set option X. Even if it would technically
work, the primary consumer of any source code is the humans who read it,
and humans read code top down.
Segher
prev parent reply other threads:[~2022-08-31 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 3:50 Peter Bergner
2022-08-31 9:22 ` Kewen.Lin
2022-08-31 13:59 ` Peter Bergner
2022-08-31 18:53 ` Peter Bergner
2022-08-31 20:51 ` Segher Boessenkool
2022-08-31 22:01 ` Peter Bergner
2022-08-31 23:08 ` Segher Boessenkool
2022-08-31 23:29 ` Peter Bergner
2022-09-01 8:29 ` Kewen.Lin
2022-09-01 14:17 ` Peter Bergner
2022-09-05 8:11 ` Kewen.Lin
2022-09-01 8:28 ` Kewen.Lin
2022-09-01 14:41 ` Segher Boessenkool
2022-08-31 15:58 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831155825.GQ25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).