From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Some predicate analysis TLC
Date: Thu, 1 Sep 2022 13:04:59 +0000 (UTC) [thread overview]
Message-ID: <20220901130459.En3wq0-pEUe0upDe__GiB7kLRwabp1HoJpfEYHpOJPQ@z> (raw)
The following hides some internal details of compute_control_dep_chain.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
* gimple-predicate-analysis.cc (compute_control_dep_chain):
New wrapping overload.
(uninit_analysis::init_use_preds): Simplify.
(uninit_analysis::init_from_phi_def): Likewise.
---
gcc/gimple-predicate-analysis.cc | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc
index eb1e11cead8..2982268fdfd 100644
--- a/gcc/gimple-predicate-analysis.cc
+++ b/gcc/gimple-predicate-analysis.cc
@@ -1124,6 +1124,18 @@ compute_control_dep_chain (basic_block dom_bb, const_basic_block dep_bb,
return found_cd_chain;
}
+static bool
+compute_control_dep_chain (basic_block dom_bb, const_basic_block dep_bb,
+ vec<edge> cd_chains[], unsigned *num_chains,
+ unsigned in_region = 0)
+{
+ auto_vec<edge, MAX_CHAIN_LEN + 1> cur_cd_chain;
+ unsigned num_calls = 0;
+ unsigned depth = 0;
+ return compute_control_dep_chain (dom_bb, dep_bb, cd_chains, num_chains,
+ cur_cd_chain, &num_calls, in_region, depth);
+}
+
/* Implemented simplifications:
1) ((x IOR y) != 0) AND (x != 0) is equivalent to (x != 0);
@@ -1919,13 +1931,10 @@ uninit_analysis::init_use_preds (predicate &use_preds, basic_block def_bb,
Each DEP_CHAINS element is a series of edges whose conditions
are logical conjunctions. Together, the DEP_CHAINS vector is
used below to initialize an OR expression of the conjunctions. */
- unsigned num_calls = 0;
unsigned num_chains = 0;
auto_vec<edge> dep_chains[MAX_NUM_CHAINS];
- auto_vec<edge, MAX_CHAIN_LEN + 1> cur_chain;
- if (!compute_control_dep_chain (cd_root, use_bb, dep_chains, &num_chains,
- cur_chain, &num_calls))
+ if (!compute_control_dep_chain (cd_root, use_bb, dep_chains, &num_chains))
{
gcc_assert (num_chains == 0);
simple_control_dep_chain (dep_chains[0], cd_root, use_bb);
@@ -2023,14 +2032,12 @@ uninit_analysis::init_from_phi_def (gphi *phi)
unsigned num_chains = 0;
auto_vec<edge> dep_chains[MAX_NUM_CHAINS];
- auto_vec<edge, MAX_CHAIN_LEN + 1> cur_chain;
for (unsigned i = 0; i < nedges; i++)
{
edge e = def_edges[i];
- unsigned num_calls = 0;
unsigned prev_nc = num_chains;
compute_control_dep_chain (cd_root, e->src, dep_chains,
- &num_chains, cur_chain, &num_calls, in_region);
+ &num_chains, in_region);
/* Update the newly added chains with the phi operand edge. */
if (EDGE_COUNT (e->src->succs) > 1)
--
2.35.3
next reply other threads:[~2022-09-01 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 13:04 Richard Biener [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-01 13:04 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901130459.En3wq0-pEUe0upDe__GiB7kLRwabp1HoJpfEYHpOJPQ@z \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).