public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling
Date: Fri,  2 Sep 2022 07:36:39 -0700	[thread overview]
Message-ID: <20220902143639.2464892-1-hjl.tools@gmail.com> (raw)

CONCAT and CONCATN never appear in the insn chain.  They are only used
in debug insn.  Ignore debug insns with CONCAT and CONCATN for insn
scheduling to avoid different insn orders with and without debug insn.

gcc/

	PR rtl-optimization/106746
	* sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT
	and CONCATN.

gcc/testsuite/

	PR rtl-optimization/106746
	* gcc.dg/pr106746.c: New test.
---
 gcc/sched-deps.cc               | 14 ++++++++++++++
 gcc/testsuite/gcc.dg/pr106746.c | 30 ++++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/pr106746.c

diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc
index 948aa0c3b60..b472e4fbb09 100644
--- a/gcc/sched-deps.cc
+++ b/gcc/sched-deps.cc
@@ -2794,6 +2794,20 @@ sched_analyze_2 (class deps_desc *deps, rtx x, rtx_insn *insn)
 
       return;
 
+    case VAR_LOCATION:
+      if (GET_CODE (PAT_VAR_LOCATION_LOC (x)) == CONCAT
+	  || GET_CODE (PAT_VAR_LOCATION_LOC (x)) == CONCATN)
+	{
+	  /* CONCAT and CONCATN never appear in the insn chain.  They
+	     are only used in debug insn.  Ignore insns with CONCAT and
+	     CONCATN for insn scheduling to avoid different insn orders
+	     with and without debug insn.  */
+	  if (cslr_p && sched_deps_info->finish_rhs)
+	    sched_deps_info->finish_rhs ();
+	  return;
+	}
+      break;
+
     default:
       break;
     }
diff --git a/gcc/testsuite/gcc.dg/pr106746.c b/gcc/testsuite/gcc.dg/pr106746.c
new file mode 100644
index 00000000000..1fc29de28c3
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr106746.c
@@ -0,0 +1,30 @@
+/* { dg-do compile } */
+/* { dg-options "-Wno-psabi -O2 -fsched2-use-superblocks -fcompare-debug" } */
+typedef char __attribute__((__vector_size__ (64))) U;
+typedef short __attribute__((__vector_size__ (64))) V;
+typedef int __attribute__((__vector_size__ (64))) W;
+
+char c;
+U a;
+U *r;
+W foo0_v512u32_0;
+
+void
+foo (W)
+{
+  U u;
+  V v;
+  W w = __builtin_shuffle (foo0_v512u32_0, foo0_v512u32_0);
+  u = __builtin_shufflevector (a, u, 3, 0, 4, 9, 9, 6,
+			       7, 8, 5, 0, 6, 1, 8, 1,
+			       2, 8, 6, 1, 8, 4, 9, 3,
+			       8, 4, 6, 0, 9, 0, 1, 8,
+			       2, 3, 3, 0, 4, 9, 9, 6,
+			       7, 8, 5, 0, 6, 1, 8, 1,
+			       2, 8, 6, 1, 8, 4, 9, 3,
+			       8, 4, 6, 0, 9, 0, 1, 8,
+			       2, 3);
+  v *= c;
+  w &= c;
+  *r = (U) v + (U) w;
+}
-- 
2.37.2


             reply	other threads:[~2022-09-02 14:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 14:36 H.J. Lu [this message]
2022-09-07 17:02 ` Jeff Law
2022-09-21 22:11   ` H.J. Lu
2022-09-24 20:37     ` Jeff Law
2022-09-26 19:52       ` H.J. Lu
2022-09-26 23:23         ` Jeff Law
2022-09-26 23:43           ` Jakub Jelinek
2022-09-27  1:40             ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220902143639.2464892-1-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).