From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id DCAB33858C53 for ; Fri, 2 Sep 2022 16:32:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCAB33858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 282GVZQX017207; Fri, 2 Sep 2022 11:31:35 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 282GVY4h017206; Fri, 2 Sep 2022 11:31:34 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 2 Sep 2022 11:31:34 -0500 From: Segher Boessenkool To: Peter Bergner Cc: "Kewen.Lin" , GCC Patches Subject: Re: [PATCH] rs6000: Use NO_EXPR to cast to MMA pointer types Message-ID: <20220902163134.GT25951@gate.crashing.org> References: <58acc8c2-b6a4-e9ec-c89b-ad841cf759ed@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58acc8c2-b6a4-e9ec-c89b-ad841cf759ed@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Fri, Sep 02, 2022 at 11:22:07AM -0500, Peter Bergner wrote: > When we cast pointers to our opaque MMA pointers, use NOP_EXPR rather > than VIEW_CONVERT_EXPR. > I think this is just a cleanup and not a correctness thing, so I'm assuming a > backport isn't needed? Or maybe we do to make other potential backports easier? > I'm fine either way. I wouldn't worry about backports. If it does make other backports easier in the future, we can decide to backport this *then*. Okay for trunk. Thanks! (Did you also look at non-MMA VIEW_CONVERT_EXPR uses btw?) Segher