From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Create internal type for null array aggregate as an itype
Date: Mon, 5 Sep 2022 09:26:12 +0200 [thread overview]
Message-ID: <20220905072612.GA1174806@poulhies-Precision-5550> (raw)
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Internal type created for the null array aggregate of Ada 2022 was
created as a temporary entity and then flagged as internal, but it is
better to create this type directly as an itype.
In particular, when the null array aggregate appears in a spec
expression, its type declaration will not be attached to the AST.
An itype will have Associated_Node_For_Itype, so that the context of
the type can be recovered, which is what GNATprove does.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_aggr.adb (Resolve_Null_Array_Aggregate): Create internal
type for the aggregate as an itype.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 859 bytes --]
diff --git a/gcc/ada/sem_aggr.adb b/gcc/ada/sem_aggr.adb
--- a/gcc/ada/sem_aggr.adb
+++ b/gcc/ada/sem_aggr.adb
@@ -4088,7 +4088,10 @@ package body Sem_Aggr is
Index : Node_Id;
Lo, Hi : Node_Id;
Constr : constant List_Id := New_List;
- Subt : constant Entity_Id := Make_Temporary (Loc, 'S');
+ Subt : constant Entity_Id :=
+ Create_Itype (Ekind => E_Array_Subtype,
+ Related_Nod => N,
+ Suffix => 'S');
begin
-- Create a constrained subtype with null dimensions
@@ -4134,7 +4137,6 @@ package body Sem_Aggr is
Make_Index_Or_Discriminant_Constraint (Loc, Constr)));
Insert_Action (N, Decl);
- Set_Is_Internal (Subt);
Analyze (Decl);
Set_Etype (N, Subt);
Set_Compile_Time_Known_Aggregate (N);
reply other threads:[~2022-09-05 7:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905072612.GA1174806@poulhies-Precision-5550 \
--to=poulhies@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).