From: Aldy Hernandez <aldyh@redhat.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Cc: Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>,
Andrew MacLeod <amacleod@redhat.com>,
Aldy Hernandez <aldyh@redhat.com>
Subject: [PATCH] Handle > INF and < INF correctly in range-op-float.cc
Date: Tue, 6 Sep 2022 09:29:01 +0200 [thread overview]
Message-ID: <20220906072901.3472801-1-aldyh@redhat.com> (raw)
The gfortran.dg/minlocval*.f90 tests are generating conditionals past
the infinities. For example:
if (x <= +Inf)
foo (x);
else
bar (x);
It seems to me that the only possible value for x on the false side is
either NAN or undefined (for !HONOR_NANS).
Is this correct, or is there some other FP nuance I'm unaware of?
gcc/ChangeLog:
* range-op-float.cc (build_lt): Handle < -INF.
(build_gt): Handle > +INF.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/vrp-float-inf-1.c: New test.
---
gcc/range-op-float.cc | 18 ++++++++++++++++++
.../gcc.dg/tree-ssa/vrp-float-inf-1.c | 15 +++++++++++++++
2 files changed, 33 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c
diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc
index 050f07a9867..4515bbf0b7e 100644
--- a/gcc/range-op-float.cc
+++ b/gcc/range-op-float.cc
@@ -235,6 +235,15 @@ build_le (frange &r, tree type, const REAL_VALUE_TYPE &val)
static void
build_lt (frange &r, tree type, const REAL_VALUE_TYPE &val)
{
+ if (real_isinf (&val, 1))
+ {
+ if (HONOR_NANS (type))
+ frange_set_nan (r, type);
+ else
+ r.set_undefined ();
+ return;
+ }
+
// Hijack LE because we only support closed intervals.
build_le (r, type, val);
}
@@ -252,6 +261,15 @@ build_ge (frange &r, tree type, const REAL_VALUE_TYPE &val)
static void
build_gt (frange &r, tree type, const REAL_VALUE_TYPE &val)
{
+ if (real_isinf (&val, 0))
+ {
+ if (HONOR_NANS (type))
+ frange_set_nan (r, type);
+ else
+ r.set_undefined ();
+ return;
+ }
+
// Hijack GE because we only support closed intervals.
build_ge (r, type, val);
}
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c
new file mode 100644
index 00000000000..1d21cce41e6
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c
@@ -0,0 +1,15 @@
+// { dg-do compile }
+// { dg-options "-O2 -fdump-tree-evrp-details" }
+
+void foo ();
+void bar (double);
+
+void funky(double f, double g)
+{
+ if (f <= __builtin_inf ())
+ foo ();
+ else
+ bar (f);
+}
+
+// { dg-final { scan-tree-dump-not " Inf, Inf" "evrp" } }
--
2.37.1
next reply other threads:[~2022-09-06 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:29 Aldy Hernandez [this message]
2022-09-06 7:35 ` Jakub Jelinek
2022-09-06 7:40 ` Aldy Hernandez
2022-09-06 7:44 ` Jakub Jelinek
2022-09-06 7:49 ` Aldy Hernandez
2022-09-06 7:59 ` Jakub Jelinek
2022-09-06 11:47 ` Aldy Hernandez
2022-09-06 12:06 ` Jakub Jelinek
2022-09-06 12:17 ` Richard Biener
2022-09-06 12:32 ` Aldy Hernandez
2022-09-06 12:38 ` Koning, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906072901.3472801-1-aldyh@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).