From: "Marc Poulhiès" <poulhies@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Steve Baird <baird@adacore.com>
Subject: [Ada] bugbox referencing INOX prefixed view of primitive op of modular type
Date: Mon, 12 Sep 2022 10:19:23 +0200 [thread overview]
Message-ID: <20220912081923.GA1512890@poulhies-Precision-5550> (raw)
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
The -gnatX switch enables naming a prefixed view of a subprogram with an
untagged prefix. Compiling such a reference where the prefix is of a modular
type could result in an internal compiler error.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_ch4.adb
(Analyze_Selected_Component): Avoid initializing the local
variable Comp if the variable is not going to be subsequently
referenced. This is a correctness issue because the call to
First_Entity can fail.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 861 bytes --]
diff --git a/gcc/ada/sem_ch4.adb b/gcc/ada/sem_ch4.adb
--- a/gcc/ada/sem_ch4.adb
+++ b/gcc/ada/sem_ch4.adb
@@ -5187,7 +5187,16 @@ package body Sem_Ch4 is
and then not Is_Derived_Type (Prefix_Type)
and then Is_Entity_Name (Name);
- Comp := First_Entity (Type_To_Use);
+ -- Avoid initializing Comp if that initialization is not needed
+ -- (and, more importantly, if the call to First_Entity could fail).
+
+ if Has_Discriminants (Type_To_Use)
+ or else Is_Record_Type (Type_To_Use)
+ or else Is_Private_Type (Type_To_Use)
+ or else Is_Concurrent_Type (Type_To_Use)
+ then
+ Comp := First_Entity (Type_To_Use);
+ end if;
-- If the selector has an original discriminant, the node appears in
-- an instance. Replace the discriminant with the corresponding one
reply other threads:[~2022-09-12 8:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912081923.GA1512890@poulhies-Precision-5550 \
--to=poulhies@adacore.com \
--cc=baird@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).