From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 9D2D138515C5 for ; Mon, 12 Sep 2022 08:19:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D2D138515C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x429.google.com with SMTP id cc5so4235772wrb.6 for ; Mon, 12 Sep 2022 01:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date; bh=EnYN6VKGvHEucoW+UwaWiSGZUOngk8RmJK3hWFVbMaA=; b=Sd/Kp0K/IO3X+c1mNosNmF+3K7NEXGKu8VUYC6la+DAH8mjLKVU9OL6vti1YG8nvBx V4yyBFlLGa5TlpjNGPuU7lIZlnI74A9FxZG+1qkNPvB1fjmZj2A0+k0dY8uunQrdGLX6 0333u6DOggR/QfGuMqE3EjFxSthOgot51Rx6Xau4Y+ggLrBaGo4Xtoz3DGA/1AMTeDXB NzmvZgbLFOozXVmbRhr24L8GectGSVrtei7+GMw278QO5tuXxQx38brNMQuL9hQ7apgM qNmAzOWBIAVRibza2zRHMuM8JyTaBDp2sP4vJOXIEtNz3Ckwi1hobdd0tSS29Qpwt7X8 /MOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=EnYN6VKGvHEucoW+UwaWiSGZUOngk8RmJK3hWFVbMaA=; b=oyY2JRnWKTLNlYrbyy/blJtqGLViM+mMFzfnv+oss0TGWBSb9TYRm8nNUp3QOujUDu af/GiPUn51X085mjDZ870kI+Sxx/9msrC8a7UMElTnCrPeW9qm9H0s9ffgu0lOyIkdel UjVPI9UuKdNRmTsX2KjxDggB60RAvn1s6O8LbmrzdF81HONCav+BrPuhYwwyfnQYukSX C1JjvL3nFr53rceZFAapxjQA37zHOskGMD7oZ98p5bBQXRjZJ+sAvAxuFHlQObKjWiNo XU8UJD+vvhJ6M67ZQkV9Yv4qDQLF0ghk3gcnVSt1HWwjFxaCGLrgUZ5Ad1wiiWhZbZYH XSrA== X-Gm-Message-State: ACgBeo2T3WReVzdfQIqIrUrIO3B09Z7jsKruO9pA9yt0ZALzAb27pD3q B2Ff2m95C1MEQHgNtaRVN3wxl0CDvYWa5w== X-Google-Smtp-Source: AA6agR5iZUNjkwa/rbE64XQ2co3BdDiag/htoKEtKXUAQsopY0EjmjvRrn6gyiTlJt6Y8Ua7aSKCAQ== X-Received: by 2002:a5d:6f19:0:b0:228:d8e8:3ac8 with SMTP id ay25-20020a5d6f19000000b00228d8e83ac8mr13669117wrb.101.1662970765258; Mon, 12 Sep 2022 01:19:25 -0700 (PDT) Received: from poulhies-Precision-5550 (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id q3-20020a05600000c300b00228d6edade0sm6607028wrx.46.2022.09.12.01.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 01:19:24 -0700 (PDT) Date: Mon, 12 Sep 2022 10:19:24 +0200 From: Marc =?iso-8859-1?Q?Poulhi=E8s?= To: gcc-patches@gcc.gnu.org Cc: Steve Baird Subject: [Ada] Syntax error in Ada 2022 array aggregate causes bug box Message-ID: <20220912081924.GA1512905@poulhies-Precision-5550> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Check for the case where a user writes "in" instead of "of" in an aggregate like "[for E in Some_Array when Some_Filter (E) => E]". Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_aggr.adb (Resolve_Array_Aggregate): Generate an appropriate error message in the case where an error in the source code leads to an N_Iterated_Element_Association node in a bad context. --82I3+IH0IqGh5yIs Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch.diff" diff --git a/gcc/ada/sem_aggr.adb b/gcc/ada/sem_aggr.adb --- a/gcc/ada/sem_aggr.adb +++ b/gcc/ada/sem_aggr.adb @@ -1987,6 +1987,11 @@ package body Sem_Aggr is while Present (Assoc) loop if Nkind (Assoc) = N_Iterated_Component_Association then Resolve_Iterated_Component_Association (Assoc, Index_Typ); + + elsif Nkind (Assoc) /= N_Component_Association then + Error_Msg_N + ("invalid component association for aggregate", Assoc); + return Failure; end if; Choice := First (Choice_List (Assoc)); --82I3+IH0IqGh5yIs--