From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id A3D3238515F0 for ; Mon, 12 Sep 2022 08:19:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3D3238515F0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x336.google.com with SMTP id m17-20020a7bce11000000b003a5bedec07bso10459380wmc.0 for ; Mon, 12 Sep 2022 01:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date; bh=SRYjTLMY83R9VwPcxtWrkmz94+7TR90KtOAG/BpTW9g=; b=N7CcZTTQVGKaAe47vwEehDOp5WbAXJ8+HZ/YAob7dztkNgjJtnBWt9+BNO81xdtipX nStxNY4acL+LH8q8a1e0hb1miO4+PLtIUa9V+UtYp5cnTIy9DW8jMCghiEo/NHAN6szX eSDK9yeh9tv/tk01O9H/r4bkJGwkQjtI4x2x4QMlNdag1sIiJrNGlMq3j1R7gNI8bokq o/ydRy0QakidKek+R8P/4f6LbEzZxH6wnkQ03zfy4ewADPnWWVA5/trdyEkD8b25Zog0 8yb4w0UE7ywmNBZaw5ljydDPn3FDC1VekcXMajo/eZHll6DHBrFprre1W63qexEOR2KY iHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=SRYjTLMY83R9VwPcxtWrkmz94+7TR90KtOAG/BpTW9g=; b=lHE80loPceS57bqezY/dvJ3dLpslx/b9IfQ7mX38+AMwwnwMtNphnqXXvMoQ/1jksJ 8UUdfLpJJHr2/wBfKT+XfrEI9OYzQZmU4pBWrY8shrfpdBVa4/k7VWq9CsVJQ4Mk6yQd o2qO6RXcyEsMjRx7Aou6huLvdK3PI4W4MWr6g7Pc09YCvPtJpsEzQRCndcpD3A3hhIrq eNu6OjhZlO6umC0DYC0NtO60uknizYiXvc7Z4wiMuATghCkNB6okjuzbHmUq5Wi0IrFK IP3NNTd/MPT8yq//fRV0bSSPczUrNZFwr2KK50oXZLqBEKgBIu1Z9gSaXMA0VKATiDV4 detw== X-Gm-Message-State: ACgBeo1Y3SyE6s6H5MOQhF3toqeFn/b/z36cfAEZ9zezpd5njNjLU3NP Wt/OOdQmGt0t8sUTJCbcbqtTgFYWNX9NxQ== X-Google-Smtp-Source: AA6agR6xcOLM70bp4a4cnxCf/n/lWf+MTIOUMrN0AuFIbF0E8yTRX5AdiSjku2I/1DYe4v1ReAnkGw== X-Received: by 2002:a05:600c:4f10:b0:3a5:f8c8:a5b5 with SMTP id l16-20020a05600c4f1000b003a5f8c8a5b5mr13201870wmq.34.1662970778354; Mon, 12 Sep 2022 01:19:38 -0700 (PDT) Received: from poulhies-Precision-5550 (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b0022863395912sm6563208wrm.53.2022.09.12.01.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 01:19:37 -0700 (PDT) Date: Mon, 12 Sep 2022 10:19:37 +0200 From: Marc =?iso-8859-1?Q?Poulhi=E8s?= To: gcc-patches@gcc.gnu.org Cc: Yannick Moy Subject: [Ada] Justify false alarm from CodePeer analysis of GNAT Message-ID: <20220912081937.GA1513056@poulhies-Precision-5550> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Branch is determined as dead following a test always False by CodePeer analysis, which is incorrect. Justify this false alarm with an appropriate pragma Annotate. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-imagei.adb (Image_Integer): Add justification. --AhhlLboLdkugWU4S Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="patch.diff" diff --git a/gcc/ada/libgnat/s-imagei.adb b/gcc/ada/libgnat/s-imagei.adb --- a/gcc/ada/libgnat/s-imagei.adb +++ b/gcc/ada/libgnat/s-imagei.adb @@ -177,6 +177,8 @@ package body System.Image_I is begin if V >= 0 then + pragma Annotate (CodePeer, False_Positive, "test always false", + "V can be positive"); S (1) := ' '; P := 1; pragma Assert (P < S'Last); --AhhlLboLdkugWU4S--